Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Jul 22, 2024

FIX #6592

Allows for ignored layers in fp8.py, like already implemented for compressed-tensors and fbgemm_fp8.
Implements the requested refactor in the above PR:

We should not make this type of logic in llama.py because it will be too difficult to maintain
Instead, let's have Fp8Config.get_quant_method(layer) extend to have the layer_name passed. Then, if the layer_name is in the ignored list we can return UnquantizedLinearMethod() from this function

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin
Copy link
Member Author

mgoin commented Jul 22, 2024

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 22, 2024
@robertgshaw2-redhat robertgshaw2-redhat merged commit 0eb0757 into main Jul 23, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@simon-mo simon-mo deleted the autofp8-ignored-layers branch October 28, 2024 16:49
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants