[Bugfix][Elastic EP] Clear scaling flag on failure to prevent permane… - #50778
Open
gagandhakrey wants to merge 2 commits into
Open
[Bugfix][Elastic EP] Clear scaling flag on failure to prevent permane…#50778gagandhakrey wants to merge 2 commits into
gagandhakrey wants to merge 2 commits into
Conversation
…nt 503s Signed-off-by: Gagan Dhakrey <gagandhakrey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Issue
ScalingMiddlewarereturns503for all HTTP requests while the process-wide_scaling_elastic_epflag is set.AsyncLLM._scale_elastic_ep()only cleared this flag on the success path. Ifengine_core.commit_elastic_ep()raised an exception or the task was cancelled,the flag remained permanently set, causing every endpoint—including
/scale_elastic_epand/health—to return503until the process restarted.Fix
Wrap the scaling operation in a single
try/finallyso_scaling_elastic_epis always cleared, regardless of success, exceptions, orcancellation. Remove the redundant cleanup from
_drain_requests_for_elastic_ep(), leaving a single owner for the flag'slifecycle.
Post-fix Impact