[Core][Distributed] support both cpu and device tensor in broadcast tensor dict #4660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 8, 2024
…-project#4660) [Core][Distributed] support both cpu and device tensor in broadcast tensor dict (vllm-project#4660)
jikunshang
reviewed
May 9, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
May 19, 2024
…-project#4660) [Core][Distributed] support both cpu and device tensor in broadcast tensor dict (vllm-project#4660)
dtrifiro
pushed a commit
to dtrifiro/vllm
that referenced
this pull request
May 21, 2024
…-project#4660) [Core][Distributed] support both cpu and device tensor in broadcast tensor dict (vllm-project#4660)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR,
broadcast_tensor_dictcan only work for cuda tensor.This PR enables both cuda tensor and cpu tensor for
broadcast_tensor_dict.It will be useful when we have some metadata in cpu tensor, e.g.
blocks_to_swap_inandblocks_to_swap_outto be introduced in #4659 .Note:
blocks_to_copyis still a cuda tensor, because the src and target for copy both lives in GPU, and we have a dedicated copy kernel for it.blocks_to_swap_inandblocks_to_swap_outhas to be cpu tensor, because they are kernel launch arguments.