Skip to content

[Bugfix] Fix dsv4 deepgemm import#42365

Closed
wzhao18 wants to merge 2 commits into
vllm-project:mainfrom
wzhao18:wzhao/fix-dsv4-deepgemm-import
Closed

[Bugfix] Fix dsv4 deepgemm import#42365
wzhao18 wants to merge 2 commits into
vllm-project:mainfrom
wzhao18:wzhao/fix-dsv4-deepgemm-import

Conversation

@wzhao18

@wzhao18 wzhao18 commented May 12, 2026

Copy link
Copy Markdown
Contributor

Purpose

Fix Dsv4 deepgemm import to use _import_deep_gemm(), which prioritizes loading from pip-installed version, instead of the hardcoded vllm.third_party.deep_gemm path. This aligns with the existing deep gemm import in the codebase, and avoids potentially importing different deepgemm modules during runtime.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@wzhao18 wzhao18 force-pushed the wzhao/fix-dsv4-deepgemm-import branch from 623ad90 to a66c8a4 Compare May 12, 2026 02:42
@mergify mergify Bot added deepseek Related to DeepSeek models bug Something isn't working labels May 12, 2026
@wzhao18

wzhao18 commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

@ywang96 found this needed when testing the deep gemm versions.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the deep_gemm import logic in deepseek_v4.py by replacing direct third-party imports with a call to the _import_deep_gemm utility function. Review feedback indicates that since this utility can return None, explicit checks should be added to prevent potential AttributeErrors and provide clearer ImportError messages. Additionally, it is suggested to refactor the duplicated import logic across multiple methods into a more maintainable helper or attribute.

Comment thread vllm/model_executor/models/deepseek_v4.py
Comment thread vllm/model_executor/models/deepseek_v4.py
Comment thread vllm/model_executor/models/deepseek_v4.py
@wzhao18 wzhao18 force-pushed the wzhao/fix-dsv4-deepgemm-import branch from a66c8a4 to ad28edf Compare May 13, 2026 17:28
wzhao18 added 2 commits May 13, 2026 12:42
Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
@wzhao18 wzhao18 force-pushed the wzhao/fix-dsv4-deepgemm-import branch from 509a44b to 11fb153 Compare May 13, 2026 19:43
@mergify

mergify Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wzhao18.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label May 23, 2026
@wzhao18 wzhao18 closed this May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working deepseek Related to DeepSeek models needs-rebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant