[Bugfix] Fix dsv4 deepgemm import#42365
Closed
wzhao18 wants to merge 2 commits into
Closed
Conversation
623ad90 to
a66c8a4
Compare
Contributor
Author
|
@ywang96 found this needed when testing the deep gemm versions. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the deep_gemm import logic in deepseek_v4.py by replacing direct third-party imports with a call to the _import_deep_gemm utility function. Review feedback indicates that since this utility can return None, explicit checks should be added to prevent potential AttributeErrors and provide clearer ImportError messages. Additionally, it is suggested to refactor the duplicated import logic across multiple methods into a more maintainable helper or attribute.
a66c8a4 to
ad28edf
Compare
Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
509a44b to
11fb153
Compare
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix Dsv4 deepgemm import to use
_import_deep_gemm(), which prioritizes loading from pip-installed version, instead of the hardcodedvllm.third_party.deep_gemmpath. This aligns with the existing deep gemm import in the codebase, and avoids potentially importing different deepgemm modules during runtime.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.