[Core] Simplifications to executor classes #4071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the common executor field-setting __init__ logic to the ExecutorBase class. - Fix incorrect return type of executor list_loras() method - Have check_health_async() implementation default to call check_health()
Member
Author
|
@zhuohan123 these are minor fixes/simplifications that I've pulled out of #3466 which aren't directly related to the multiprocessing. Having this merged would help reduce the continual rebasing pain with that one! 🙏 (unless there are any of these changes that you don't like of course, which is fine) |
zhuohan123
approved these changes
Apr 15, 2024
Member
zhuohan123
left a comment
zhuohan123
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the refactoring!
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 21, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
Apr 22, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__init__logic to theExecutorBaseclass.tensorizer_configarg toExecutorBase.__init__()list_loras()methodcheck_health_async()implementation default to callcheck_health()