[Misc] Clean up model registry#37457
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Mar 18, 2026
Merged
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
Isotr0py
approved these changes
Mar 18, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request provides a good cleanup of the model registry by removing unnecessary noqa comments, reformatting code for better readability, and reordering model entries alphabetically. The introduction of _OOT_SUPPORTED_MODELS is a valuable addition, as it improves user experience by providing clear guidance for models that have been moved to out-of-tree plugins. The implementation is straightforward and correct. I have not found any issues of high or critical severity.
DarkLight1337
commented
Mar 18, 2026
| } | ||
|
|
||
| _OOT_SUPPORTED_MODELS = { | ||
| "BartModel": "https://github.com/vllm-project/bart-plugin", |
Member
Author
There was a problem hiding this comment.
cc @NickLucche can you update the plugin to map BartModel and MBartForConditionalGeneration as well?
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
SouthWest7
pushed a commit
to SouthWest7/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang
pushed a commit
to EricccYang/vllm
that referenced
this pull request
Apr 1, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: EricccYang <yangyang4991@gmail.com>
liuchenbing2026
pushed a commit
to liuchenbing2026/vllm
that referenced
this pull request
Apr 4, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
noqas and put items on one line where possible._OOT_SUPPORTED_MODELSso that we can redirect previous users of BART and Florence-2 to the OOT plugin.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.