Skip to content

Conversation

@declark1
Copy link
Contributor

This PR exposes additional uvicorn TLS args ssl_ca_certs, ssl_cert_reqs to enable mTLS support.

@simon-mo simon-mo merged commit c17ca8e into vllm-project:main Mar 14, 2024
@ywang96
Copy link
Member

ywang96 commented Mar 15, 2024

@simon-mo Hmmm...this PR probably shouldn't be merged in the first place since it's making changes to vllm/entrypoints/api_server.py. I wonder if we should make a workflow to automatically warn user if the changes are being made to that file.

@declark1 Could you please make a PR to add this to vllm/entrypoints/openai/api_server.py as well?

@declark1
Copy link
Contributor Author

Thanks for pointing this out @ywang96, my apologies for missing that. I have opened a new PR to fix this.

@simon-mo
Copy link
Collaborator

I merged this because benchmarking over mTLS is a valid use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants