[Bugfix] Interleaved thinking keeps compatibility with reasoning_content #33635
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a compatibility issue by ensuring the reasoning_content field is populated for interleaved thinking, alongside the reasoning field. The change in _parse_chat_message_content is straightforward and correctly implements this for backward compatibility. The implementation is sound, and I have no high-severity concerns with this patch.
5 tasks
Signed-off-by: chaunceyjiang <[email protected]> Co-authored-by: Koushik Dutta <[email protected]>
chaunceyjiang
force-pushed
the
reasoning_content_compatibility
branch
from
149b346 to
d92de88
Compare
koush
reviewed
Feb 3, 2026
koush
approved these changes
Feb 3, 2026
chaunceyjiang
added
the
ready
Collaborator
Author
|
@DarkLight1337 PTAL. |
DarkLight1337
approved these changes
Feb 3, 2026
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
…ent (vllm-project#33635) Signed-off-by: chaunceyjiang <[email protected]> Co-authored-by: Koushik Dutta <[email protected]> Signed-off-by: Pai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
FIX #33616
introduced by #33402
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.