Skip to content

Conversation

@esmeetu
Copy link
Member

@esmeetu esmeetu commented Mar 12, 2024

A parameter is missing: use_ray_compiled_dag in RayGPUExecutorAsync after merging #3191.

@zhuohan123 Could you help test this whether is ok when use_ray_compiled_dag=True, please. Because that feature doesn't work on my machine. It seems a DevelopAPI in ray.

@esmeetu esmeetu requested a review from zhuohan123 March 12, 2024 08:28
@cadedaniel
Copy link
Collaborator

cc @rkooo567

Copy link
Collaborator

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature is under active development. It should work though (you may need more than certain version of ray).

Btw, it is surprising this wasn't caught by any CI. Do we have tests for async engines?

@zhuohan123
Copy link
Member

The feature is under active development. It should work though (you may need more than certain version of ray).

Btw, it is surprising this wasn't caught by any CI. Do we have tests for async engines?

This thing hits a strange corner case. It will only be wrong when we run async engines distributedly with ray. We should add a test on this.

@zhuohan123
Copy link
Member

@esmeetu Let's use the simpler fix in #3371 instead?

@rkooo567
Copy link
Collaborator

@cadedaniel for our internal version, do we have unit test for this case? I'd love to upstream it if there is

@esmeetu esmeetu closed this Mar 14, 2024
@cadedaniel
Copy link
Collaborator

@esmeetu esmeetu deleted the fix-async-engine branch March 23, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants