Skip to content

Conversation

@vllmellm
Copy link
Contributor

@vllmellm vllmellm commented Jan 6, 2026

Purpose

Running deepseek using the AITER_TRITON_MLA backend results in low accuracy as follow:
command:
export VLLM_USE_V1=1 export SAFETENSORS_FAST_GPU=1 export VLLM_ROCM_USE_AITER=1 export VLLM_ATTENTION_BACKEND=ROCM_AITER_TRITON_MLA vllm serve deepseek-ai/DeepSeek-V3 -tp 8
lm_eval score:

Tasks Version Filter n-shot Metric Value Stderr
gsm8k 3 flexible-extract 5 exact_match 0.0067 ± 0.0047
strict-match 5 exact_match 0.0000 ± 0.0000

This PR fixes the issue by inheriting from AiterMLABackend instead of MLACommonBackend since AiterMLABackend in shared for aiter triton backend as well.

Test Plan

verify lm_eval score

export VLLM_USE_V1=1 export SAFETENSORS_FAST_GPU=1 export VLLM_ROCM_USE_AITER=1 export VLLM_ATTENTION_BACKEND=ROCM_AITER_TRITON_MLA vllm serve deepseek-ai/DeepSeek-V3 -tp 8

lm_eval --model local-completions \ --tasks gsm8k \ --model_args model=deepseek-ai/DeepSeek-V3,base_url=http://localhost:8000/v1/completions \ --trust_remote_code \ --num_fewshot 5 \ --limit 300 \ --batch_size 128

Test Result

Tasks Version Filter n-shot Metric Value Stderr
gsm8k 3 flexible-extract 5 exact_match 0.96 ± 0.0113
strict-match 5 exact_match 0.96 ± 0.0113

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@vllmellm vllmellm requested a review from tjtanaa as a code owner January 6, 2026 16:03
@mergify mergify bot added rocm Related to AMD ROCm v1 labels Jan 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a critical accuracy regression in the ROCM_AITER_TRITON_MLA attention backend. The fix involves changing the base class of AiterTritonMLABackend from MLACommonBackend to AiterMLABackend. This change correctly allows AiterTritonMLABackend to inherit necessary configurations, like get_supported_kernel_block_sizes, from the shared AiterMLABackend, which is the intended base for AITer backends on ROCm. The changes also include cleaning up imports and removing a redundant method override, improving code clarity. The fix is logical, well-contained, and its effectiveness is demonstrated by the significant improvement in the provided lm_eval scores.

Copy link
Collaborator

@tjtanaa tjtanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing it.

@tjtanaa tjtanaa added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 7, 2026
@tjtanaa tjtanaa enabled auto-merge (squash) January 7, 2026 03:08
@tjtanaa tjtanaa merged commit 6409004 into vllm-project:main Jan 7, 2026
54 of 55 checks passed
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants