[ROCm][AITER] bugfix accuracy regression in ROCM_AITER_TRITON_MLA backend #31816
+2
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Running deepseek using the AITER_TRITON_MLA backend results in low accuracy as follow:
command:
export VLLM_USE_V1=1 export SAFETENSORS_FAST_GPU=1 export VLLM_ROCM_USE_AITER=1 export VLLM_ATTENTION_BACKEND=ROCM_AITER_TRITON_MLA vllm serve deepseek-ai/DeepSeek-V3 -tp 8lm_eval score:
This PR fixes the issue by inheriting from
AiterMLABackendinstead ofMLACommonBackendsince AiterMLABackend in shared for aiter triton backend as well.Test Plan
verify lm_eval score
export VLLM_USE_V1=1 export SAFETENSORS_FAST_GPU=1 export VLLM_ROCM_USE_AITER=1 export VLLM_ATTENTION_BACKEND=ROCM_AITER_TRITON_MLA vllm serve deepseek-ai/DeepSeek-V3 -tp 8lm_eval --model local-completions \ --tasks gsm8k \ --model_args model=deepseek-ai/DeepSeek-V3,base_url=http://localhost:8000/v1/completions \ --trust_remote_code \ --num_fewshot 5 \ --limit 300 \ --batch_size 128Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.