[Doc] Reorganize benchmark docs #29658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <[email protected]>
|
Documentation preview: https://vllm--29658.org.readthedocs.build/en/29658/ |
Signed-off-by: DarkLight1337 <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request does a great job of reorganizing the benchmark documentation into its own dedicated section, which significantly improves discoverability. The content has been split into logical pages for CLI, parameter sweeps, and the performance dashboard. My review focuses on ensuring the correctness of the documentation after this refactoring. I've found several broken links (to source files and images) that were likely missed during the file moves. I've provided suggestions to fix these incorrect relative paths.
DarkLight1337
force-pushed
the
reorganize-benchmark-docs
branch
from
ad096cd to
c9ffb59
Compare
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
force-pushed
the
reorganize-benchmark-docs
branch
2 times, most recently
from
2062055 to
7fd2fd8
Compare
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
force-pushed
the
reorganize-benchmark-docs
branch
from
7fd2fd8 to
ef6882d
Compare
DarkLight1337
added
the
ready
Signed-off-by: DarkLight1337 <[email protected]>
Isotr0py
approved these changes
Nov 28, 2025
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
Signed-off-by: DarkLight1337 <[email protected]>
amd-hhashemi
pushed a commit
to amd-hhashemi/vllm
that referenced
this pull request
Dec 2, 2025
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Hashem Hashemi <[email protected]>
charlotte12l
pushed a commit
to charlotte12l/vllm
that referenced
this pull request
Dec 5, 2025
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Xingyu Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The benchmark documentation is getting a bit long, so let's split it up into multiple pages.
Also, since benchmarks can also be done by users who want to optimize the settings, I have made Benchmarks its own tab.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.