[CI/Test Fix] Fix CP tests on Blackwell #29338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Wilkinson <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix a CI test on Blackwell by removing an assertion. However, this change is problematic as it hides a deeper issue. The assertion assert out.is_contiguous() was added for a valid reason: downstream distributed operations like reduce_scatter require contiguous tensors. Removing it will likely lead to runtime errors. The root cause is that correct_attn_out no longer guarantees a contiguous output after a previous partial revert. The correct solution is to restore the logic in correct_attn_out to ensure its output is always contiguous.
mgoin
added
bug
bringlein
pushed a commit
to bringlein/vllm
that referenced
this pull request
Nov 26, 2025
Signed-off-by: Lucas Wilkinson <[email protected]>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Lucas Wilkinson <[email protected]>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
Signed-off-by: Lucas Wilkinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28718 inadvertently undid part of #28404