[Attention] Add ROCM_AITER_MLA_SPARSE to attention backend registry #29103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Bonanni <[email protected]>
MatthewBonanni
requested review from
LucasWilkinson and
tjtanaa
as code owners
MatthewBonanni
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request registers a new attention backend, ROCM_AITER_MLA_SPARSE, and refactors the code to use the new enum member instead of a hardcoded string. The changes are a good improvement for maintainability. However, I've identified a critical issue in the implementation of the new backend that will prevent it from being used. The backend class is missing necessary method overrides, which will cause validation to fail during backend selection.
mgoin
approved these changes
Nov 20, 2025
LuminolT
pushed a commit
to LuminolT/vllm
that referenced
this pull request
Nov 21, 2025
…llm-project#29103) Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: LuminolT <[email protected]>
ywang96
pushed a commit
to ywang96/vllm
that referenced
this pull request
Nov 23, 2025
…llm-project#29103) Signed-off-by: Matthew Bonanni <[email protected]>
lpapavassiliou
pushed a commit
to lpapavassiliou/vllm
that referenced
this pull request
Nov 24, 2025
…llm-project#29103) Signed-off-by: Matthew Bonanni <[email protected]>
RunkaiTao
pushed a commit
to RunkaiTao/vllm
that referenced
this pull request
Nov 24, 2025
…llm-project#29103) Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: Runkai Tao <[email protected]>
bringlein
pushed a commit
to bringlein/vllm
that referenced
this pull request
Nov 26, 2025
…llm-project#29103) Signed-off-by: Matthew Bonanni <[email protected]>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…llm-project#29103) Signed-off-by: Matthew Bonanni <[email protected]>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
…llm-project#29103) Signed-off-by: Matthew Bonanni <[email protected]>
charlotte12l
pushed a commit
to charlotte12l/vllm
that referenced
this pull request
Dec 5, 2025
…llm-project#29103) Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: Xingyu Liu <[email protected]>
Zhathw
pushed a commit
to Zhathw/vllm
that referenced
this pull request
Dec 6, 2025
…llm-project#29103) Signed-off-by: Matthew Bonanni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds the new
ROCM_AITER_MLA_SPARSEbackend introduced by #26670 to the attention backend registry.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.