Skip to content

Align LoRA code between Mistral and Mixtral (fixes #2875) #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2024
Merged

Align LoRA code between Mistral and Mixtral (fixes #2875) #2880

merged 3 commits into from
Feb 15, 2024

Conversation

@pcmoritz
Copy link
Collaborator

@pcmoritz pcmoritz commented Feb 14, 2024 •
edited
Loading

This aligns the LoRA code between Mistral and Mixtral and fixes #2875 as a result.

@pcmoritz pcmoritz mentioned this pull request Feb 14, 2024
Closed
@pcmoritz
Copy link
Collaborator Author

pcmoritz commented Feb 14, 2024

This would have actually been caught by export CUDA_VISIBLE_DEVICES=0,1,2,3 ; pytest -v -s lora/test_mixtral.py but unfortunately in the CI that's skipped at the moment because there are not enough GPUs available. But I ran it manually to verify the fix :)

Yard1
Yard1 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Yard1 Yard1 merged commit 31348df into vllm-project:main Feb 15, 2024
@WoosukKwon WoosukKwon mentioned this pull request Feb 15, 2024
Closed
5 tasks
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2024
@pcmoritz @Pernekhan
Align LoRA code between Mistral and Mixtral (fixes vllm-project#2875) (…
fcf5cb3 
…vllm-project#2880)

* Fix AttributeError: MixtralModel object has no attribute org_vocab_size.

* Make LoRA logic for Mistral and Mixtral the same

---------

Co-authored-by: Pernekhan Utemuratov <[email protected]>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 22, 2024
@pcmoritz @Pernekhan
Align LoRA code between Mistral and Mixtral (fixes vllm-project#2875) (…
211242f 
…vllm-project#2880)

* Fix AttributeError: MixtralModel object has no attribute org_vocab_size.

* Make LoRA logic for Mistral and Mixtral the same

---------

Co-authored-by: Pernekhan Utemuratov <[email protected]>
@andy-neuma andy-neuma mentioned this pull request Feb 23, 2024
Closed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Mar 4, 2024
@pcmoritz @Pernekhan
Align LoRA code between Mistral and Mixtral (fixes vllm-project#2875) (…
de4941f 
…vllm-project#2880)

* Fix AttributeError: MixtralModel object has no attribute org_vocab_size.

* Make LoRA logic for Mistral and Mixtral the same

---------

Co-authored-by: Pernekhan Utemuratov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yard1 Yard1 Yard1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcmoritz @Yard1 @Pernekhan