-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[Performance][Fix] update nvfp4 code to support renorm routing #28569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yewentao256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work!
pavanimajety
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, LGTM.
Signed-off-by: jiahanc <[email protected]>
Signed-off-by: jiahanc <[email protected]>
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
…project#28569) Signed-off-by: jiahanc <[email protected]> Co-authored-by: Michael Goin <[email protected]> Signed-off-by: Bram Wasti <[email protected]>
…project#28569) Signed-off-by: jiahanc <[email protected]> Co-authored-by: Michael Goin <[email protected]>
…project#28569) Signed-off-by: jiahanc <[email protected]> Co-authored-by: Michael Goin <[email protected]>
…project#28569) Signed-off-by: jiahanc <[email protected]> Co-authored-by: Michael Goin <[email protected]>
…project#28569) Signed-off-by: jiahanc <[email protected]> Co-authored-by: Michael Goin <[email protected]> Signed-off-by: Xingyu Liu <[email protected]>
…project#28569) Signed-off-by: jiahanc <[email protected]> Co-authored-by: Michael Goin <[email protected]>
Purpose
Fixes #28007
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.