[BugFix] Fix Failing Ruff Check #28469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan van Lunteren <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a failing ruff check in tests/compile/test_fusions_e2e.py by replacing an incorrect enum _Backend.TRITON_ATTN with the correct AttentionBackendEnum.TRITON_ATTN. The change is correct, straightforward, and makes the code consistent with other usages in the file. The PR looks good to merge.
hmellor
approved these changes
Nov 11, 2025
github-actions
bot
added
the
ready
mgoin
approved these changes
Nov 11, 2025
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Jan van Lunteren <[email protected]>
charlotte12l
pushed a commit
to charlotte12l/vllm
that referenced
this pull request
Dec 5, 2025
Signed-off-by: Jan van Lunteren <[email protected]> Signed-off-by: Xingyu Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix failing ruff check due to an issue in
tests/compile/test_fusions_e2e.py.Test Plan
Run
pre-commit run --all-filesTest Result
ruff check........................Passed@tdoublep @bringlein