Revert "[Kernel] Fuse computation of g and beta for Gated Delta Net" #28293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llm-project#28095)" This reverts commit c18f88c.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that fused the computation of g and beta for the Gated Delta Net. The reason for the revert is to fix a bug that reportedly caused NaN values. The changes correctly separate the computation of beta from the fused_gdn_gating Triton kernel, moving it back to a PyTorch sigmoid operation. The modifications to the fused_gdn_gating function and its underlying Triton kernel fused_gdn_gating_kernel are consistent and correctly remove the logic for beta computation. The revert appears to be complete and correct, addressing the reported issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #28095
This PR makes b contain Nan sometimes