Skip to content

Conversation

@ywang96
Copy link
Member

@ywang96 ywang96 commented Oct 27, 2025

Purpose

#27566 introduced a regression where remote models (e.g, deepseek-ai/deepseek-vl2) without architectures will be not deploy-able even with --hf_overrides '{"architectures": ["DeepseekVLV2ForCausalLM"]}' on vLLM because of a strict model type check. This PR relaxes this check and adds a warning when this happens.

This also fixes the failed entrypoints/test_chat_utils.py::test_resolve_content_format_fallbacks[deepseek-ai/deepseek-vl2-tiny-string] CI test on main.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Roger Wang <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a regression for remote models that don't have an architectures field in their configuration by relaxing a strict check on model_type. While the intention is correct, the implementation introduces a new issue by using "AutoModel" as a dummy architecture. This will cause a runtime error because "AutoModel" is a real class in the transformers library that doesn't conform to vLLM's expectations for model classes. I've provided a critical comment with a suggested fix to use a unique placeholder name and also simplify the logic.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: Roger Wang <[email protected]>
@ywang96
Copy link
Member Author

ywang96 commented Oct 27, 2025

/gemini review

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a regression where remote models lacking an architectures field in their configuration would fail to load, even when the architecture was supplied through hf_overrides. The fix correctly relaxes a strict check, replacing a ValueError with a logger.warning. This allows the model loading to proceed so that the hf_overrides can be applied later. The change is well-targeted and effectively resolves the described issue.

@mgoin mgoin enabled auto-merge (squash) October 27, 2025 22:40
@mgoin mgoin merged commit a8d2e32 into vllm-project:main Oct 28, 2025
50 checks passed
@DarkLight1337
Copy link
Member

Sorry I missed it, thanks for fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants