-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
Load tuned fused_moe_lora shrink and expand kernel configs separately #27435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 33 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
567ef62
Adding config loading and benchmarking for fused_moe_lora shrink and …
yugong333 d3364e9
fix some bugs
yugong333 9a5f9e0
your message
yugong333 7d3071d
fix bugs
yugong333 1724bdb
fix bugs
yugong333 e8d144f
Fixed the bugs
yugong333 64537e2
Adding pre-commit-config.yaml
yugong333 b09466c
clean the code
yugong333 d9cb741
fix bugs
yugong333 0bf6a53
Adding support in benchmark_lora for fused_moe_lora expand and shrink…
yugong333 94508e4
Adding data generation for fused_moe_lora
yugong333 6c8c97b
Fix bugs
yugong333 8e85f95
Adding accuracy test
yugong333 0ee933b
fix bugs
yugong333 f9f0f8e
fix bugs
yugong333 e11030e
clean code
yugong333 82635d5
fix pre-commit
yugong333 5553bda
fix bugs
yugong333 0d8fa61
clean code
yugong333 3b1f04a
clean code
yugong333 3ad93dd
clean code
yugong333 3f6357f
clean code
yugong333 3acf93b
restore pre-commit-config.yaml
yugong333 ff518b3
restore .pre-commit-config.yaml
yugong333 dfb9dd1
clean code
yugong333 d950b3d
clean code
yugong333 65c11e9
clean code
yugong333 f451ca7
rename the config
yugong333 22faf7e
clean code
yugong333 0b439f7
fix format issue
yugong333 a1ec116
Rabase PR
yugong333 d73f410
Renaming kernel
yugong333 51f00b2
renaming
yugong333 50afb56
Normalize key name as uppercase
yugong333 221b287
fix bugs
yugong333 1542c93
fix bugs
yugong333 623278e
Merge branch 'main' into restore-pr
jeejeelee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to lower-case all keys of the configs here so we dont have to do the
config.get("UPPER_CASE", None) or config.get("lower_case")check everywhere ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @varun-sundar-rabindranath I add an function to normalize the key name into upper case to be consistent with the moe layer config name, which also is able to remove the name check everywhere.