[CI] Fix mypy for `vllm/v1/core` and `vllm/v1/engine` #27108

yewentao256 · 2025-10-17T15:09:43Z

Purpose

FIx mypy for vllm/v1/core and vllm/v1/engine

Test

pre-commit run --hook-stage manual mypy-3.10 -a
Found 31 errors in 9 files (checked 249 source files)

pre-commit run --hook-stage manual mypy-3.10 -a
Run mypy for Python 3.10.................................................Passed

Signed-off-by: yewentao256 <[email protected]>

gemini-code-assist

Code Review

This pull request introduces fixes to address mypy errors in vllm/v1/core and vllm/v1/engine. The changes primarily involve adding type hints, explicit casts, and safer attribute access patterns to improve type safety and satisfy mypy checks.

I've found one critical issue in vllm/v1/engine/llm_engine.py where the new logic for processing request outputs can lead to data loss by incorrectly filtering a list of mixed-type results. I've provided a detailed comment and a suggested fix for this issue.

Other changes appear correct and effectively address the mypy errors.

vllm/v1/engine/llm_engine.py

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR.

@codex fix this CI failure
@codex address that feedback

vllm/v1/engine/llm_engine.py

Signed-off-by: yewentao256 <[email protected]>

yewentao256 · 2025-10-21T14:36:56Z

@hmellor CC

vllm/v1/engine/output_processor.py

vllm/v1/engine/llm_engine.py

vllm/v1/engine/core_client.py

hmellor · 2025-10-21T14:49:51Z

vllm/v1/engine/async_llm.py


    async def is_tracing_enabled(self) -> bool:
-        return self.observability_config.otlp_traces_endpoint is not None
+        return self.observability_config.otlp_traces_endpoint is not None  # type: ignore


Why does the type need to be ignored here? Should this not always return a bool?

The issue is vllm/v1/engine/async_llm.py:661: error: Item "None" of "ObservabilityConfig | None" has no attribute "otlp_traces_endpoint" [union-attr]

async def is_tracing_enabled(self) -> bool: assert self.observability_config is not None return self.observability_config.otlp_traces_endpoint is not None

I think this is not very elegant so just #type ignore

hmellor · 2025-10-21T14:50:47Z

vllm/v1/engine/core.py

+        if hasattr(self.model_executor, "save_tensorized_model"):
+            self.model_executor.save_tensorized_model(  # type: ignore[attr-defined]
+                tensorizer_config=tensorizer_config,
+            )


This should probably error if we if the model executor doesn't have this method

Just to confirm, you meant we should raise an error here in case the model executor doesn't have this method?

vllm/v1/engine/core.py

vllm/v1/engine/async_llm.py

mergify · 2025-10-21T20:41:10Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @yewentao256.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Signed-off-by: yewentao256 <[email protected]>

vllm/v1/engine/output_processor.py

vllm/v1/core/sched/scheduler.py

Signed-off-by: yewentao256 <[email protected]>

yewentao256 · 2025-10-28T20:22:17Z

Hi @hmellor, wondering is there anything else we should update?

DarkLight1337 · 2025-10-30T12:22:03Z

This PR is failing pre-commit on main

NickLucche · 2025-10-30T13:36:44Z

@DarkLight1337 this wasn't force-merged right? Can we still break pre-commit with a clean-merge..?

DarkLight1337 · 2025-10-30T13:38:00Z

It wasn't. But this PR was behind main when it was merged.

…7108) Signed-off-by: yewentao256 <[email protected]>

njhill · 2025-10-30T18:40:02Z

😢

yewentao256 · 2025-10-30T19:30:53Z

@DarkLight1337 Is there any way we can avoid this? A clean merge shouldn't cause trouble to CI

hmellor · 2025-10-30T20:19:48Z

It happens when a PR changes a pre-commit rule.

PR1 makes a change to a pre-commit rule (like this PR with mypy) and CI starts
PR2 makes a change that would fail this new rule but the CI starts in parallel without the new rule applied
Both PRs merge cleanly and now pre-commit fails on main

The best way to prevent this is to always merge from main before attempting to merge a PR which changes pre-commit rules.

…7108) Signed-off-by: yewentao256 <[email protected]>

…7108) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Eldar Kurtic <[email protected]>

…7108) Signed-off-by: yewentao256 <[email protected]>

fix mypy for core and engine

8244ff7

Signed-off-by: yewentao256 <[email protected]>

yewentao256 requested review from ApostaC, WoosukKwon, alexm-redhat, comaniac, heheda12345, hmellor, njhill, robertgshaw2-redhat and ywang96 as code owners October 17, 2025 15:09

yewentao256 mentioned this pull request Oct 17, 2025

[Feature]: Fix all of the mypy check #26533

Open

8 tasks

mergify bot added the v1 label Oct 17, 2025

gemini-code-assist bot reviewed Oct 17, 2025

View reviewed changes

vllm/v1/engine/llm_engine.py Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Oct 17, 2025

View reviewed changes

vllm/v1/engine/llm_engine.py Outdated Show resolved Hide resolved

fix mypy

60ae003

Signed-off-by: yewentao256 <[email protected]>

yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 17, 2025

yewentao256 added 3 commits October 17, 2025 12:53

Merge branch 'main' into wentao-fix-mypy-v1

3565e69

Merge branch 'main' into wentao-fix-mypy-v1

8bae154

Merge branch 'main' into wentao-fix-mypy-v1

463e3d3

hmellor reviewed Oct 21, 2025

View reviewed changes

mergify bot added the needs-rebase label Oct 21, 2025

update through comments

e90cb02

Signed-off-by: yewentao256 <[email protected]>

yewentao256 requested review from ProExpertProg, houseroad, mgoin, simon-mo, tlrmchlsmth and youkaichao as code owners October 21, 2025 20:56

yewentao256 requested review from 22quinn and zhuohan123 as code owners October 21, 2025 20:56

Merge branch 'main' into wentao-fix-mypy-v1

4f4f6e7

Signed-off-by: yewentao256 <[email protected]>

mergify bot removed the needs-rebase label Oct 21, 2025

hmellor reviewed Oct 23, 2025

View reviewed changes

vllm/v1/engine/output_processor.py Outdated Show resolved Hide resolved

vllm/v1/engine/output_processor.py Show resolved Hide resolved

vllm/v1/core/sched/scheduler.py Outdated Show resolved Hide resolved

yewentao256 added 2 commits October 24, 2025 15:39

Merge remote-tracking branch 'origin/main' into wentao-fix-mypy-v1

2105a7e

update

a6ec06a

Signed-off-by: yewentao256 <[email protected]>

hmellor approved these changes Oct 30, 2025

View reviewed changes

hmellor enabled auto-merge (squash) October 30, 2025 10:11

hmellor merged commit c01f6e5 into main Oct 30, 2025
53 checks passed

hmellor deleted the wentao-fix-mypy-v1 branch October 30, 2025 11:32

DarkLight1337 mentioned this pull request Oct 30, 2025

[Bugfix] Fix 2 precommit issues - (mamba_block_size, kv_cache_config) #27811

Merged

MatthewBonanni pushed a commit to MatthewBonanni/vllm that referenced this pull request Oct 30, 2025

[CI] Fix mypy for vllm/v1/core and vllm/v1/engine (vllm-project#2…

c9501e5

…7108) Signed-off-by: yewentao256 <[email protected]>

ilmarkov pushed a commit to neuralmagic/vllm that referenced this pull request Nov 7, 2025

[CI] Fix mypy for vllm/v1/core and vllm/v1/engine (vllm-project#2…

05fd241

…7108) Signed-off-by: yewentao256 <[email protected]>

ZhengHongming888 pushed a commit to ZhengHongming888/vllm that referenced this pull request Nov 8, 2025

[CI] Fix mypy for vllm/v1/core and vllm/v1/engine (vllm-project#2…

7f8d421

…7108) Signed-off-by: yewentao256 <[email protected]>

rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025

[CI] Fix mypy for vllm/v1/core and vllm/v1/engine (vllm-project#2…

851755c

…7108) Signed-off-by: yewentao256 <[email protected]>

eldarkurtic pushed a commit to eldarkurtic/vllm that referenced this pull request Nov 12, 2025

[CI] Fix mypy for vllm/v1/core and vllm/v1/engine (vllm-project#2…

32200bb

…7108) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Eldar Kurtic <[email protected]>

devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025

[CI] Fix mypy for vllm/v1/core and vllm/v1/engine (vllm-project#2…

eef7774

…7108) Signed-off-by: yewentao256 <[email protected]>

Uh oh!

[CI] Fix mypy for vllm/v1/core and vllm/v1/engine #27108

[CI] Fix mypy for vllm/v1/core and vllm/v1/engine #27108

Uh oh!

Conversation

yewentao256 commented Oct 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Test

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

yewentao256 commented Oct 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hmellor Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

yewentao256 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

hmellor Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

yewentao256 Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Oct 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yewentao256 commented Oct 28, 2025

Uh oh!

Uh oh!

DarkLight1337 commented Oct 30, 2025

Uh oh!

NickLucche commented Oct 30, 2025

Uh oh!

DarkLight1337 commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

njhill commented Oct 30, 2025

Uh oh!

yewentao256 commented Oct 30, 2025

Uh oh!

hmellor commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[CI] Fix mypy for `vllm/v1/core` and `vllm/v1/engine` #27108

[CI] Fix mypy for `vllm/v1/core` and `vllm/v1/engine` #27108

yewentao256 commented Oct 17, 2025 •

edited by github-actions bot

Loading

yewentao256 Oct 21, 2025 •

edited

Loading

DarkLight1337 commented Oct 30, 2025 •

edited

Loading