[Misc] Remove isort and yapf ignores#26888
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Oct 15, 2025
Merged
Conversation
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
requested review from
mgoin,
robertgshaw2-redhat,
sighingnow,
tlrmchlsmth and
yewentao256
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request focuses on code cleanup by removing unnecessary isort and yapf ignore directives across several files. The changes correctly refactor import statements, leading to better adherence to the project's formatting standards. The modifications are purely stylistic and do not introduce any functional changes or issues. The codebase is now cleaner and more maintainable. The changes look good.
hmellor
approved these changes
Oct 15, 2025
Member
There was a problem hiding this comment.
When making the original PR removing yapf I did see this one and wondered if the import order mattered.
Member
Author
There was a problem hiding this comment.
Let's run the CI and see if it still passes
Member
Author
There was a problem hiding this comment.
Ok seems that the order is indeed important...
github-actions
bot
added
the
ready
Signed-off-by: DarkLight1337 <[email protected]>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: bbartels <[email protected]>
albertoperdomo2
pushed a commit
to albertoperdomo2/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Alberto Perdomo <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: DarkLight1337 <[email protected]>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: DarkLight1337 <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: 0xrushi <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: 0xrushi <[email protected]>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: DarkLight1337 <[email protected]>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: DarkLight1337 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove unnecessary ignore directives
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.