Skip to content

[CI] Fix mypy for vllm/executor#26845

Merged
vllm-bot merged 1 commit intomainfrom
wentao-fix-mypy-executor
Oct 15, 2025
Merged

[CI] Fix mypy for vllm/executor#26845
vllm-bot merged 1 commit intomainfrom
wentao-fix-mypy-executor

Conversation

@yewentao256
Copy link
Copy Markdown
Member

@yewentao256 yewentao256 commented Oct 14, 2025

Purpose

Part of the #26533

Test

(vllm-user-6) vllm-user-6@centralia:~/vllm-source$ pre-commit run --hook-stage manual mypy-3.10 -a
Run mypy for Python 3.10.................................................Passed

Signed-off-by: yewentao256 <[email protected]>
@yewentao256 yewentao256 changed the title [CI] Fix Mypy Executor [CI] Fix mypy for vllm/executor Oct 14, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on fixing mypy type checking errors, primarily by moving the vllm/executor module to a group with stricter checks. The changes involve adding more precise type hints, using assert statements for type narrowing, and suppressing unavoidable mypy errors in Ray actor code with # type: ignore. These modifications improve the codebase's type safety and are well-aligned with the goal of resolving CI issues. The changes appear correct and I have no high or critical severity concerns.

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 14, 2025
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This directory is V0 code which will be removed soon anyways, I think there is not much value in fixing mypy here

@hmellor
Copy link
Copy Markdown
Member

hmellor commented Oct 15, 2025

Given that the work has been done and the tests pass, could we merge anyway?

The timeline for removal of all remaining V0 code is uncertain and doing this would allow us to push forward with running mypy directly instead of via our complicated script.

Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then

@vllm-bot vllm-bot merged commit 71557a5 into main Oct 15, 2025
55 of 56 checks passed
@vllm-bot vllm-bot deleted the wentao-fix-mypy-executor branch October 15, 2025 08:23
bbartels pushed a commit to bbartels/vllm that referenced this pull request Oct 16, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: bbartels <[email protected]>
albertoperdomo2 pushed a commit to albertoperdomo2/vllm that referenced this pull request Oct 16, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Alberto Perdomo <[email protected]>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants