Skip to content

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Oct 13, 2025

TL;DR

Pooling models now default support all pooling, you can use it without any settings.

  • Extracting hidden states prefers using token_embed task.
  • Reward models prefers using token_classify task.

Add jina_embeddings_v4 example

Improve all pooling task

These PRs are mostly conflicting with each other, so combining them into a series would better inform reviewers about what happened. And what else needs to be done after that?

Purpose

Fix #25165

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@noooop noooop marked this pull request as draft October 13, 2025 08:00
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates and removes the as_reward_model adapter, along with its usage in tests and model loading utilities. The changes are straightforward and correctly implemented. This refactoring improves the API by removing a generic adapter that was used for extracting hidden states, encouraging more explicit methods. The code modifications are sound and I have no specific comments on the changes.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

@noooop noooop changed the title [Model][5/N] Improve all pooling task | Deprecation as_reward_model. Extract hidden states prefer using new multi-vector retrieval API [Model][6/N] Improve all pooling task | Deprecation as_reward_model. Extract hidden states prefer using new multi-vector retrieval API Oct 14, 2025
@mergify
Copy link

mergify bot commented Oct 16, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @noooop.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Oct 16, 2025
@noooop noooop changed the title [Model][6/N] Improve all pooling task | Deprecation as_reward_model. Extract hidden states prefer using new multi-vector retrieval API [Model][7/N] Improve all pooling task | Deprecation as_reward_model. Extract hidden states prefer using new multi-vector retrieval API Oct 17, 2025
@noooop noooop changed the title [Model][7/N] Improve all pooling task | Deprecation as_reward_model. Extract hidden states prefer using new multi-vector retrieval API [Model][8/N] Improve all pooling task | Deprecation as_reward_model. Extract hidden states prefer using new multi-vector retrieval API Nov 11, 2025
@noooop noooop changed the title [Model][8/N] Improve all pooling task | Deprecation as_reward_model. Extract hidden states prefer using new multi-vector retrieval API [Model][7/N] Improve all pooling task | Deprecation as_reward_model. Extract hidden states prefer using new multi-vector retrieval API Dec 4, 2025
@noooop noooop closed this Dec 4, 2025
@noooop noooop force-pushed the deprecation_as_reward_model branch from d254342 to ad32e3e Compare December 4, 2025 03:07
Signed-off-by: wang.yuqi <[email protected]>
@noooop noooop reopened this Dec 8, 2025
@mergify
Copy link

mergify bot commented Dec 8, 2025

Documentation preview: https://vllm--26686.org.readthedocs.build/en/26686/

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 8, 2025
@mergify
Copy link

mergify bot commented Dec 8, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @noooop.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@noooop
Copy link
Collaborator Author

noooop commented Dec 8, 2025

@jupyterjazz

Finally, we managed to support jinaai/jina-embeddings-v4-vllm-text-matching. That's great If you can help review.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 8, 2025 04:35
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 8, 2025
@mergify
Copy link

mergify bot commented Dec 8, 2025

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

@noooop noooop disabled auto-merge December 8, 2025 05:06
Signed-off-by: wang.yuqi <[email protected]>
@mergify
Copy link

mergify bot commented Dec 8, 2025

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

@noooop noooop enabled auto-merge (squash) December 8, 2025 06:51
@noooop noooop merged commit 9e77ffc into vllm-project:main Dec 8, 2025
57 checks passed
@noooop noooop deleted the deprecation_as_reward_model branch December 8, 2025 08:40
mayoohee pushed a commit to mayoohee/vllm that referenced this pull request Dec 9, 2025
…Extract hidden states prefer using new multi-vector retrieval API (vllm-project#26686)

Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: mayoohee <[email protected]>
ilmarkov pushed a commit to neuralmagic/vllm that referenced this pull request Dec 9, 2025
…Extract hidden states prefer using new multi-vector retrieval API (vllm-project#26686)

Signed-off-by: wang.yuqi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: "pooling_type='ALL' no longer supported for embeddings

2 participants