-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
[Model][7/N] Improve all pooling task | Deprecation as_reward_model. Extract hidden states prefer using new multi-vector retrieval API #26686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request deprecates and removes the as_reward_model adapter, along with its usage in tests and model loading utilities. The changes are straightforward and correctly implemented. This refactoring improves the API by removing a generic adapter that was used for extracting hidden states, encouraging more explicit methods. The code modifications are sound and I have no specific comments on the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
|
This pull request has merge conflicts that must be resolved before it can be |
d254342 to
ad32e3e
Compare
Signed-off-by: wang.yuqi <[email protected]>
|
Documentation preview: https://vllm--26686.org.readthedocs.build/en/26686/ |
|
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Finally, we managed to support jinaai/jina-embeddings-v4-vllm-text-matching. That's great If you can help review. |
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
|
Hi @noooop, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
Signed-off-by: wang.yuqi <[email protected]>
|
Hi @noooop, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
…Extract hidden states prefer using new multi-vector retrieval API (vllm-project#26686) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: mayoohee <[email protected]>
…Extract hidden states prefer using new multi-vector retrieval API (vllm-project#26686) Signed-off-by: wang.yuqi <[email protected]>
TL;DR
Pooling models now default support all pooling, you can use it without any settings.
token_embedtask.token_classifytask.Add jina_embeddings_v4 example
Improve all pooling task
These PRs are mostly conflicting with each other, so combining them into a series would better inform reviewers about what happened. And what else needs to be done after that?
Purpose
Fix #25165
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.