[ci] Rename test_mxfp4_moe.py to test_ocp_mx_moe.py
#26364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Marty <[email protected]>
fxmarty-amd
requested review from
mgoin,
robertgshaw2-redhat and
yewentao256
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly updates the test file name from test_mxfp4_moe.py to test_ocp_mx_moe.py in the .buildkite/test-pipeline.yaml CI configuration and in a docstring within tests/quantization/test_quark.py. The changes are correct and resolve the issue of the CI configuration being out of sync with the renamed test file. The PR looks good to merge.
mgoin
approved these changes
Oct 7, 2025
patrickvonplaten
pushed a commit
to patrickvonplaten/vllm
that referenced
this pull request
Oct 7, 2025
…#26364) Signed-off-by: Felix Marty <[email protected]> Signed-off-by: Patrick von Platen <[email protected]>
patrickvonplaten
pushed a commit
to patrickvonplaten/vllm
that referenced
this pull request
Oct 7, 2025
…#26364) Signed-off-by: Felix Marty <[email protected]> Signed-off-by: Patrick von Platen <[email protected]>
patrickvonplaten
pushed a commit
to patrickvonplaten/vllm
that referenced
this pull request
Oct 7, 2025
…#26364) Signed-off-by: Felix Marty <[email protected]> Signed-off-by: Patrick von Platen <[email protected]>
mrasquinha-g
pushed a commit
to mrasquinha-g/vllm
that referenced
this pull request
Oct 9, 2025
…#26364) Signed-off-by: Felix Marty <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…#26364) Signed-off-by: Felix Marty <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Dhruvilbhatt
pushed a commit
to Dhruvilbhatt/vllm
that referenced
this pull request
Oct 14, 2025
…#26364) Signed-off-by: Felix Marty <[email protected]> Signed-off-by: Dhruvil Bhatt <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…#26364) Signed-off-by: Felix Marty <[email protected]>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…#26364) Signed-off-by: Felix Marty <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…#26364) Signed-off-by: Felix Marty <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…#26364) Signed-off-by: Felix Marty <[email protected]>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…#26364) Signed-off-by: Felix Marty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, as reported in #21166 (comment)
test_mxfp4_moe.pywas renamed, but not in.buildkite/test-pipeline.yaml.Not sure why the CI was green on the above PR.