[CI] fix mamba kernel test

[ZJY0516]

Purpose

test_causal_conv1d.py::test_causal_conv1d_update was broken due to #25752

Test Plan

pytest -v -s tests/kernels/mamba/test_causal_conv1d.py::test_causal_conv1d_update

Test Result

---

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
• (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

[gemini-code-assist]

Code Review

This pull request addresses a broken test, test_causal_conv1d_update, by adding the conv_state_indices parameter to the causal_conv1d_update function call. The fix is straightforward and correct, providing the necessary indices for the convolution state. The change is well-contained within the test file and appears to resolve the issue as described. I have no further comments or suggestions.

[mergify]

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @ZJY0516.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

[tdoublep]

Looks good but can we also address why this test is not running in CI when we change code that breaks it?

[ZJY0516]

I'm also curious about it. However, I'm not very familiar with our CI setup.

[hmellor]

The test wouldn't have run because no files in source_file_dependencies were changed in the original PR

vllm/.buildkite/test-pipeline.yaml

Lines 474 to 481 in 1c0c682

	- label: Kernels Mamba Test # 31min
	timeout_in_minutes: 45
	mirror_hardwares: [amdexperimental]
	source_file_dependencies:
	- csrc/mamba/
	- tests/kernels/mamba
	commands:
	- pytest -v -s kernels/mamba

You could add vllm/model_executor/layers/mamba to the list for example

[ZJY0516]

The test wouldn't have run because no files in source_file_dependencies were changed in the original PR

vllm/.buildkite/test-pipeline.yaml

Lines 474 to 481 in 1c0c682

	- label: Kernels Mamba Test # 31min
	timeout_in_minutes: 45
	mirror_hardwares: [amdexperimental]
	source_file_dependencies:
	- csrc/mamba/
	- tests/kernels/mamba
	commands:
	- pytest -v -s kernels/mamba

You could add vllm/model_executor/layers/mamba to the list for example

Thanks very much!

[hmellor]

Not sure if that is the correct file to trigger the Mamba kernel CI though, @tdoublep could you confirm which file from the original PR should have triggered this test?

[tdoublep]

Not sure if that is the correct file to trigger the Mamba kernel CI though, @tdoublep could you confirm which file from the original PR should have triggered this test?

I think we should add vllm/model_executor/layers/mamba/ops which contains the kernel code

[ZJY0516]

Not sure if that is the correct file to trigger the Mamba kernel CI though, @tdoublep could you confirm which file from the original PR should have triggered this test?

I think we should add vllm/model_executor/layers/mamba/ops which contains the kernel code

I have updated it.

[tdoublep]

Thanks for the fix!