Skip to content

Conversation

@rzabarazesh
Copy link
Collaborator

@rzabarazesh rzabarazesh commented Oct 2, 2025

Purpose

This is to fix coverage results not being merged correctly due to tests having differing working_dirs.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@yeqcharlotte
Copy link
Collaborator

any test plan? this wouldn't impact vllm/vllm/ right?

@rzabarazesh
Copy link
Collaborator Author

any test plan? this wouldn't impact vllm/vllm/ right?

CI is currently broken. Waiting for it to be fixed so I can run a few test builds: #26065 (review)

@mergify mergify bot added the ci/build label Oct 2, 2025
@rzabarazesh rzabarazesh force-pushed the coveragerc-fix branch 2 times, most recently from 6c6f18f to 3d7b547 Compare October 3, 2025 02:17
@rzabarazesh rzabarazesh closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants