Skip to content

Conversation

@yitingdc
Copy link
Contributor

@yitingdc yitingdc commented Sep 26, 2025

Follow up #24986

Fix doc build waring:

image

Purpose

if this warning exists, other pr cannot doc validation cannot passed

https://app.readthedocs.org/projects/vllm/builds/29726695/

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a documentation build warning by adjusting the indentation in a docstring. While the change silences the warning, it doesn't address the root cause, which is an incorrect nesting of a parameter in the docstring. My review provides a code suggestion to fix the docstring's structure, making it both correct and more readable. This also ensures that documentation generation tools will parse it correctly in the future.

Copy link
Collaborator

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

@chaunceyjiang chaunceyjiang added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 26, 2025
@chaunceyjiang chaunceyjiang changed the title fix doc build warning: Failed to get 'name: description' pair [CI/Build] fix doc build warning: Failed to get 'name: description' pair Sep 26, 2025
@chaunceyjiang chaunceyjiang enabled auto-merge (squash) September 26, 2025 05:01
@chaunceyjiang
Copy link
Collaborator

buildkite/ci/pr/v1-test-others

track #25745

@vllm-bot vllm-bot merged commit 3edf87d into vllm-project:main Sep 26, 2025
51 of 53 checks passed
pdasigi pushed a commit to pdasigi/vllm that referenced this pull request Oct 2, 2025
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants