[V0 Deprecation] Remove more V0 tests #25117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Woosuk Kwon <[email protected]>
WoosukKwon
requested review from
DarkLight1337,
NickLucche,
aarnphm,
njhill,
robertgshaw2-redhat and
simon-mo
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes a significant number of tests related to the deprecated V0 engine, which is a good cleanup effort. The changes in the CI configuration and the removal of V0-specific test files seem correct. However, I've identified one critical issue where a test file that appears to cover both V0 and V1 engines is being removed, potentially reducing test coverage for the V1 engine. Please see the detailed comment.
Signed-off-by: Woosuk Kwon <[email protected]>
zhuohan123
approved these changes
Sep 18, 2025
Signed-off-by: Woosuk Kwon <[email protected]>
845473182
pushed a commit
to dsxsteven/vllm_splitPR
that referenced
this pull request
Sep 18, 2025
…litPR into model_register * 'model_register' of https://github.com/dsxsteven/vllm_splitPR: (138 commits) Retrieve `sliding_window` from text config in Gemma3 MM (vllm-project#25085) [Docs] Fix API Reference (vllm-project#25140) [Kernel] Better inf handling for grouped topk cu (vllm-project#24886) [CLI] Use streaming in CLI chat and completion commands (vllm-project#23769) [benchmark] add peak throughput metrics and plot (vllm-project#23867) [Spec Decode] Efficient padded speculation (vllm-project#24539) [V0 Deprecation] Remove more V0 tests (vllm-project#25117) [EPLB] Add EPLB support for hunyuan_v1 (vllm-project#23078) [XPU] Whisper model support on XPU Platform (vllm-project#25123) Mark prompt logprobs as incompatible with prompt embeds at API level (vllm-project#25077) [Model] enable data parallel for InternVL vision encoder (vllm-project#23909) [Kernels] Overlap shared experts with combine instead of dispatch (vllm-project#24254) [Bugfix][Qwen3-Next] add prefixes to shared_expert in qwen3-next and mlp in qwen2moe to successfully load ignored params in quantized models (vllm-project#24960) [Core][MM] Cleanup `MultiModalCache` (vllm-project#25006) [Docs] Clean up the contributing README (vllm-project#25099) [MM Encoder] Apply DP ViT for Qwen3-VL model series (vllm-project#24955) [Kernels] Enable DeepGEMM by default (vllm-project#24462) [V0 Deprecation] Skip PP test (vllm-project#25128) [V0 Deprecation] Remove misc V0 tests (vllm-project#25118) [V0 Deprecation] Remove V0 Tracing & Metrics tests (vllm-project#25115) ...
debroy-rh
pushed a commit
to debroy-rh/vllm
that referenced
this pull request
Sep 19, 2025
Signed-off-by: Woosuk Kwon <[email protected]>
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 20, 2025
They have been removed in vllm-project/vllm#25117 and vllm-project/vllm#22772, thus failing in trunk at the moment after the latest pin commit update Pull Request resolved: #163383 Approved by: https://github.com/wdvr, https://github.com/seemethere, https://github.com/malfet
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
They have been removed in vllm-project/vllm#25117 and vllm-project/vllm#22772, thus failing in trunk at the moment after the latest pin commit update Pull Request resolved: pytorch#163383 Approved by: https://github.com/wdvr, https://github.com/seemethere, https://github.com/malfet
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
They have been removed in vllm-project/vllm#25117 and vllm-project/vllm#22772, thus failing in trunk at the moment after the latest pin commit update Pull Request resolved: pytorch#163383 Approved by: https://github.com/wdvr, https://github.com/seemethere, https://github.com/malfet
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Woosuk Kwon <[email protected]>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: charlifu <[email protected]>
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
They have been removed in vllm-project/vllm#25117 and vllm-project/vllm#22772, thus failing in trunk at the moment after the latest pin commit update Pull Request resolved: pytorch#163383 Approved by: https://github.com/wdvr, https://github.com/seemethere, https://github.com/malfet
pytorchbot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 30, 2025
They have been removed in vllm-project/vllm#25117 and vllm-project/vllm#22772, thus failing in trunk at the moment after the latest pin commit update Pull Request resolved: #163383 Approved by: https://github.com/wdvr, https://github.com/seemethere, https://github.com/malfet (cherry picked from commit a31acf3)
Camyll
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 30, 2025
Clean up obsoleted vLLM tests (#163383) They have been removed in vllm-project/vllm#25117 and vllm-project/vllm#22772, thus failing in trunk at the moment after the latest pin commit update Pull Request resolved: #163383 Approved by: https://github.com/wdvr, https://github.com/seemethere, https://github.com/malfet (cherry picked from commit a31acf3) Co-authored-by: Huy Do <[email protected]>
1 task
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
Signed-off-by: Woosuk Kwon <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.