Fix model name included in responses #24663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harry Mellor <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the logic for determining the model name in responses to fix an issue where --served-model-name was being ignored. The logic is centralized into a new OpenAIServingModels.model_name method, and all call sites are updated accordingly. The change correctly enforces the use of the served model name, which aligns with the stated goal. I have one critical suggestion to prevent a potential server crash.
Member
DarkLight1337
left a comment
DarkLight1337
left a comment
There was a problem hiding this comment.
Can you add a regression test?
Signed-off-by: Harry Mellor <[email protected]>
hmellor
requested review from
NickLucche,
robertgshaw2-redhat and
simon-mo
as code owners
Signed-off-by: Harry Mellor <[email protected]>
DarkLight1337
approved these changes
Sep 11, 2025
github-actions
bot
added
the
ready
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
Signed-off-by: Harry Mellor <[email protected]>
dsxsteven
pushed a commit
to dsxsteven/vllm_splitPR
that referenced
this pull request
Sep 15, 2025
Signed-off-by: Harry Mellor <[email protected]>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Harry Mellor <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13568 made the
modelparameter optional when making requests to vLLM. Unfortunately, this broke the behaviour of https://docs.vllm.ai/en/latest/cli/serve.html#-served-model-name.This PR reinstates the original behaviour (while still allowing the
modelparameter to be optional).Fixes #15845