-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[Docs] add docs for cuda graph v1 #24374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: fhl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new design document for CUDA Graph v1, which is a great addition for understanding the new features. The document is comprehensive and well-structured. My main feedback is on the language quality of the new document, which has numerous typos and grammatical errors. I've left a single comment with a list of examples. Fixing these will significantly improve the document's quality. The update to torch_compile.md to link to this new document is appropriate.
Signed-off-by: fhl <[email protected]>
Signed-off-by: fhl <[email protected]>
hmellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I've not looked closely at the content of the document yet but I have left some high level comments that can be actioned in the meantime.
Signed-off-by: fhl2000 <[email protected]>
hmellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With V0 effectively gone, we can drop V1 from the title
Signed-off-by: fhl2000 <[email protected]>
Signed-off-by: fhl2000 <[email protected]>
Signed-off-by: fhl2000 <[email protected]>
Signed-off-by: fhl <[email protected]>
Signed-off-by: fhl <[email protected]>
Signed-off-by: fhl <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
hmellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could you remove the
Pre:andNow:labels baked into the images and useBefore:andAfter:in the markdown content to introduce the images? - Could you also not truncate
PIECEWISEtoPIECE.? IKt's not explained anywhere and only saves 3 characters, it's better to be explicit.
|
Why did the pre-commit fail? @hmellor I remember previously it asked for |
Sorry this was my mistake. |
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: fhl <[email protected]>
|
Any thoughts on this new pre-commit error? Maybe just remove -- |
Signed-off-by: fhl2000 <[email protected]>
Signed-off-by: fhl2000 <[email protected]>
|
The notes for attention ops fusion is changed, since #24281 merged! |
Signed-off-by: fhl2000 <[email protected]>
Signed-off-by: fhl2000 <[email protected]>
Signed-off-by: fhl2000 <[email protected]>
Signed-off-by: fhl2000 <[email protected]>
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
Signed-off-by: fhl2000 <[email protected]>
My formatting requests have been addressed
Signed-off-by: fhl2000 <[email protected]>
ProExpertProg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this increadible writeup! A few thoughts & suggestions below
Co-authored-by: Luka Govedič <[email protected]> Signed-off-by: fhl2000 <[email protected]>
Co-authored-by: Luka Govedič <[email protected]> Signed-off-by: fhl2000 <[email protected]>
Signed-off-by: fhl2000 <[email protected]>
Signed-off-by: fhl2000 <[email protected]>
ProExpertProg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for writing this up!
Signed-off-by: fhl <[email protected]> Signed-off-by: fhl2000 <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Co-authored-by: Luka Govedič <[email protected]>
Signed-off-by: fhl <[email protected]> Signed-off-by: fhl2000 <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Co-authored-by: Luka Govedič <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: fhl <[email protected]> Signed-off-by: fhl2000 <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Co-authored-by: Luka Govedič <[email protected]> Signed-off-by: Dhruvil Bhatt <[email protected]>
Signed-off-by: fhl <[email protected]> Signed-off-by: fhl2000 <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Co-authored-by: Luka Govedič <[email protected]>
Signed-off-by: fhl <[email protected]> Signed-off-by: fhl2000 <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Co-authored-by: Luka Govedič <[email protected]>
Signed-off-by: fhl <[email protected]> Signed-off-by: fhl2000 <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Co-authored-by: Luka Govedič <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: fhl <[email protected]> Signed-off-by: fhl2000 <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Co-authored-by: Luka Govedič <[email protected]>
Signed-off-by: fhl <[email protected]> Signed-off-by: fhl2000 <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Co-authored-by: Luka Govedič <[email protected]>


Purpose
Add design documents for the changes in #20059.
Previews:
https://vllm--24374.org.readthedocs.build/en/24374/design/cuda_graphs.html
https://vllm--24374.org.readthedocs.build/en/24374/design/torch_compile.html
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.