[Bugfix] Avoid uninitialized usage of azp_val when AZP is false. #24335
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an uninitialized variable usage of azp_val when AZP is false by initializing it and scale_val before the conditional block. My review includes a suggestion to optimize the change by avoiding a redundant function call, which improves performance.
mohankku
force-pushed
the
fix/dnnl-quantization-optimization
branch
from
4162b3d to
03aebd7
Compare
mohankku
force-pushed
the
fix/dnnl-quantization-optimization
branch
2 times, most recently
from
7b3e71f to
3ff4634
Compare
|
LGTM, please also fix the failed DCO check. |
Added |
mohankku
force-pushed
the
fix/dnnl-quantization-optimization
branch
2 times, most recently
from
b0e3763 to
f8f052c
Compare
- Avoid uninitialized usage of azp_val when AZP is false - Optimize max_scalar calculation to avoid redundant reduce_max() calls - Improve code efficiency and readability in dynamic_scaled_int8_quant_impl Signed-off-by: Mohan Kumar Kumar <[email protected]> Signed-off-by: mohankku <[email protected]>
mohankku
force-pushed
the
fix/dnnl-quantization-optimization
branch
from
f8f052c to
9d638aa
Compare
github-actions
bot
added
the
ready
…m-project#24335) Signed-off-by: Mohan Kumar Kumar <[email protected]> Signed-off-by: mohankku <[email protected]>
…m-project#24335) Signed-off-by: Mohan Kumar Kumar <[email protected]> Signed-off-by: mohankku <[email protected]>
…m-project#24335) Signed-off-by: Mohan Kumar Kumar <[email protected]> Signed-off-by: mohankku <[email protected]>
…m-project#24335) Signed-off-by: Mohan Kumar Kumar <[email protected]> Signed-off-by: mohankku <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
…m-project#24335) Signed-off-by: Mohan Kumar Kumar <[email protected]> Signed-off-by: mohankku <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
3 participants
Purpose
Fix uninitialized usage of azp_val. Initialize scale and azp_val outside the AZP conditional block.
Test Plan
Build cpu version with instructions in
https://docs.vllm.ai/en/stable/getting_started/installation/cpu.html
Test Result
Build successful.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.