[Docs]add eplb_config param use docs #24213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@abmfy please take a look. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for Expert Parallel Load Balancer (EPLB) parameters, introducing the new --eplb-config argument. My review focuses on ensuring the new documentation is accurate and clear for users. I've found that the added documentation for the new configuration method is potentially misleading and contains some minor errors. I've provided a suggestion to correct this by removing the confusing parts and presenting the information in a clearer way.
lengrongfu
force-pushed
the
docs/add-eplb-param
branch
from
6b6810e to
024b0a2
Compare
hmellor
reviewed
Sep 4, 2025
lengrongfu
force-pushed
the
docs/add-eplb-param
branch
4 times, most recently
from
cf47746 to
4644ce0
Compare
Contributor
Author
hmellor
reviewed
Sep 8, 2025
hmellor
reviewed
Sep 8, 2025
hmellor
reviewed
Sep 8, 2025
Member
hmellor
left a comment
hmellor
left a comment
There was a problem hiding this comment.
This LGTM now, just a couple of nits
Signed-off-by: rongfu.leng <[email protected]>
Signed-off-by: rongfu.leng <[email protected]>
Signed-off-by: rongfu.leng <[email protected]>
lengrongfu
force-pushed
the
docs/add-eplb-param
branch
from
4644ce0 to
24e3ebc
Compare
hmellor
approved these changes
Sep 8, 2025
Member
hmellor
left a comment
hmellor
left a comment
There was a problem hiding this comment.
LGTM, thanks fir the docs update!
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
Signed-off-by: rongfu.leng <[email protected]>
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
Signed-off-by: rongfu.leng <[email protected]>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: rongfu.leng <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: rongfu.leng <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: rongfu.leng <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
#20562 (comment)
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.