Skip to content

[CI/Build] Disable SiluMul NVFP4 quant fusion tests #24121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

[CI/Build] Disable SiluMul NVFP4 quant fusion tests #24121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb04b04
Disable test_silu_nvfp4_quant_fusion
MatthewBonanni Sep 2, 2025
390045a
Also need to disable test_silu_mul_quant_fusion
MatthewBonanni Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .buildkite/test-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ steps:
# Quantization
- pytest -v -s tests/kernels/quantization/test_cutlass_scaled_mm.py -k 'fp8'
- pytest -v -s tests/kernels/quantization/test_nvfp4_quant.py
- pytest -v -s tests/kernels/quantization/test_silu_nvfp4_quant_fusion.py
# - pytest -v -s tests/kernels/quantization/test_silu_nvfp4_quant_fusion.py
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Commenting out this test run disables it for all platforms, including those where it is intended to run. This results in a loss of test coverage for the silu_nvfp4_quant_fusion feature.

A better approach is to allow pytest to succeed even when no tests are collected. If the project uses pytest version 7.0 or newer, you can add the --allow-no-tests flag. This will cause pytest to exit with code 0 (success) instead of 5 when no tests are found, resolving the CI issue without sacrificing test coverage on supported platforms.

If using an older version of pytest, other options could be considered, such as wrapping the command in shell logic to ignore exit code 5.

    - pytest -v -s --allow-no-tests tests/kernels/quantization/test_silu_nvfp4_quant_fusion.py

Copy link
Member

@njhill njhill Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatthewBonanni that sounds like a better option, could we add --allow-no-tests with a comment?

Copy link
Contributor Author

@MatthewBonanni MatthewBonanni Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njhill pytest doesn't recognize --allow-no-tests as an option (I'm on 8.4.1) and I can't find it documented online anywhere. I think gemini may have hallucinated that. There are definitely other workarounds though, like I could add a dummy test that passes or something

Copy link
Contributor Author

@MatthewBonanni MatthewBonanni Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njhill note: needed to disable a second test as well (see #23671)

Copy link
Member

@njhill njhill Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice gemini hallucination

- pytest -v -s tests/kernels/quantization/test_nvfp4_scaled_mm.py
- pytest -v -s tests/kernels/quantization/test_flashinfer_scaled_mm.py
- pytest -v -s tests/kernels/quantization/test_flashinfer_nvfp4_scaled_mm.py
Expand All @@ -676,7 +676,7 @@ steps:
- pytest -v -s tests/compile/test_fusion_all_reduce.py
- pytest -v -s tests/compile/test_fusion_attn.py::test_attention_quant_pattern
- pytest -v -s tests/kernels/moe/test_flashinfer.py
- pytest -v -s tests/compile/test_silu_mul_quant_fusion.py
# - pytest -v -s tests/compile/test_silu_mul_quant_fusion.py

##### 1 GPU test #####
##### multi gpus test #####
Expand Down