-
-
Notifications
You must be signed in to change notification settings - Fork 12k
[CI] Add nightly builds to dockerhub #24102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sahithi Chigurupati <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Buildkite step for publishing nightly multi-arch images to DockerHub, along with a script for cleaning up older images. The overall approach is good, but I've identified a critical issue in the cleanup script. The script incorrectly sorts tags alphabetically instead of chronologically, which could lead to the deletion of recent builds. My review provides a correction to ensure tags are sorted by their update timestamp, thus ensuring the oldest builds are removed as intended.
nWEIdia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Nit:
The manifest publishing workflow seems to be a bit duplicative of
https://github.com/vllm-project/vllm/blob/e0653f6c0b9f331af0877e7c7abc99a85efc3982/.buildkite/scripts/annotate-release.sh
Existing workflow may already support the publish to vllm/vllm-openai:latest
See: https://github.com/vllm-project/vllm/blob/e0653f6c0b9f331af0877e7c7abc99a85efc3982/.buildkite/scripts/annotate-release.sh#L26C1-L27C65
Is it possible to re-use annotate release script?
|
@nWEIdia The annotate release script is being used to publish specific versions of x86 builds to dockerhub as you can see here: https://hub.docker.com/r/vllm/vllm-openai/tags and seems like this is not scheduled. In this PR, since we want to see two weeks worth of nightly builds on dockerhub, I'm directly fetching the multiarch manifest from AWS and publishing it to dockerhub as nightly. Pls let me know if you have comments on this. |
|
docker pull public.ecr.aws/q9t5s3a7/vllm-release-repo:${BUILDKITE_COMMIT} I like the newly added functionality of nightly tag and only keeping 14 commits, but I just wasn't sure about the fact that this PR would introduce a 2nd write-interface to the vllm/vllm-openai , with delete. e.g. If an "official" release has happened, and a commit tagged, how do you handle the 14 commits deletion? Would your workflow delete the official commit release? |
|
cc @simon-mo who might have already visioned how the vllm/vllm-openai nightly tags would like and how we are going to maintain nightly docker images and their tags. |
|
I agree, defer to @simon-mo for more comments on this |
Signed-off-by: Sahithi Chigurupati <[email protected]>
|
Hi @simon-mo @youkaichao Is there anything remaining that you want us to check before merging this PR? |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Simon Mo <[email protected]>
|
Let me create a nightly schedule for the pipeline and test it out |
Signed-off-by: simon-mo <[email protected]>
|
FYI, cross link the nightly release job: https://buildkite.com/vllm/release/builds/8011/steps/canvas |
|
Thanks @simon-mo for merging! We need additional help as it looks like we did not configure docker vllm/vllm-openai authentication. Has the push to vllm/vllm-openai always been done manually or there is CI setup with token authentication to do that? |
Signed-off-by: Sahithi Chigurupati <[email protected]> Signed-off-by: Simon Mo <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: Simon Mo <[email protected]>
Signed-off-by: Sahithi Chigurupati <[email protected]> Signed-off-by: Simon Mo <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: Simon Mo <[email protected]>
Signed-off-by: Sahithi Chigurupati <[email protected]> Signed-off-by: Simon Mo <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: Simon Mo <[email protected]>
Signed-off-by: Sahithi Chigurupati <[email protected]> Signed-off-by: Simon Mo <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: Sahithi Chigurupati <[email protected]> Signed-off-by: Simon Mo <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: Simon Mo <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Purpose
Publish nightly builds to dockerhub and retain builds only for the last 14 days
cc: @kushanam @sgodithi1
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.