(Misc): add missing test for zero truncation size. #23457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teekenl
requested review from
DarkLight1337,
aarnphm,
robertgshaw2-redhat and
simon-mo
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a test case for truncate_prompt_tokens with a value of 0, which is a good addition for coverage. However, the new asynchronous test function is missing the necessary @pytest.mark.asyncio decorator, which will prevent it from running correctly. This is a critical issue that needs to be addressed.
teekenl
force-pushed
the
add-test-zero-truncation
branch
from
874bc1c to
e59a389
Compare
DarkLight1337
approved these changes
Aug 23, 2025
github-actions
bot
added
the
ready
Signed-off-by: teekenl <[email protected]>
auto-merge was automatically disabled
August 24, 2025 06:22
Head branch was pushed to by a user without write access
teekenl
force-pushed
the
add-test-zero-truncation
branch
from
e59a389 to
46d69e5
Compare
jeejeelee
approved these changes
Aug 24, 2025
johnnynunez
pushed a commit
to johnnynunez/vllm
that referenced
this pull request
Aug 24, 2025
Signed-off-by: teekenl <[email protected]> Signed-off-by: johnnynunez <[email protected]>
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 28, 2025
Signed-off-by: teekenl <[email protected]>
xiao-llm
pushed a commit
to xiao-llm/vllm
that referenced
this pull request
Aug 28, 2025
Signed-off-by: teekenl <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
Signed-off-by: teekenl <[email protected]>
mengxingkongzhouhan
pushed a commit
to mengxingkongzhouhan/vllm
that referenced
this pull request
Aug 30, 2025
Signed-off-by: teekenl <[email protected]>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Sep 3, 2025
Signed-off-by: teekenl <[email protected]>
ekagra-ranjan
pushed a commit
to ekagra-ranjan/vllm
that referenced
this pull request
Sep 4, 2025
Signed-off-by: teekenl <[email protected]> Signed-off-by: Ekagra Ranjan <[email protected]>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: teekenl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When going through
_validate_truncation_size, realised that we are missing a test case when the truncation size is set to0. Add a new test case to ensure no prompt tokens are truncated when it is actually0. It should raises error when input tokens are too long.Test Plan
Add "test_zero_truncation_size" new test case
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.