Skip to content

Conversation

@lengrongfu
Copy link
Contributor

@lengrongfu lengrongfu commented Aug 21, 2025

Purpose

Test Plan

Test Result

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request comments out the logic for handling eplb_config, which is critical for expert parallelism load balancing. The title "[Test] test remove this code after ci" strongly suggests this is a temporary change for testing and should not be merged in its current state. If this functionality is intended to be removed, the code should be deleted rather than commented out. Otherwise, it must be restored before merging.

Comment on lines 458 to 460
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change comments out the logic for processing eplb_config. Based on the pull request title, this appears to be a temporary change for testing purposes. Merging this as-is would break the expert parallelism load balancing configuration. This code should be restored before merging.

Suggested change
# if isinstance(self.eplb_config, dict):
# self.eplb_config = EPLBConfig.from_cli(json.dumps(
# self.eplb_config))
if isinstance(self.eplb_config, dict):
self.eplb_config = EPLBConfig.from_cli(json.dumps(
self.eplb_config))

@lengrongfu lengrongfu force-pushed the feat/add-eplb-config-new branch from afd50f6 to 919346a Compare August 21, 2025 08:32
@lengrongfu lengrongfu changed the title [Test] test remove this code after ci [Misc] update dict parse to EPLBConfig from json dumps to dict unpacking Aug 21, 2025
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hmellor hmellor enabled auto-merge (squash) August 21, 2025 09:07
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 21, 2025
@hmellor hmellor merged commit 1b9b166 into vllm-project:main Aug 24, 2025
38 of 39 checks passed
johnnynunez pushed a commit to johnnynunez/vllm that referenced this pull request Aug 24, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
mengxingkongzhouhan pushed a commit to mengxingkongzhouhan/vllm that referenced this pull request Aug 30, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
ekagra-ranjan pushed a commit to ekagra-ranjan/vllm that referenced this pull request Sep 4, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@lengrongfu lengrongfu deleted the feat/add-eplb-config-new branch October 21, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants