-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
Update docs for Minimax-Text support #22562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates documentation to reflect Minimax-Text model support. The changes correctly mark MiniMaxText01ForCausalLM as supported in V1. However, there's an inconsistency regarding MiniMaxM1ForCausalLM. While docs/usage/v1_guide.md states it's supported, docs/models/supported_models.md is not updated to reflect this. Since both models use the same implementation, MiniMaxM1ForCausalLM should also be marked as V1 supported in the table for consistency.
87ab7b3 to
ad09273
Compare
cad5556 to
cd72c2e
Compare
|
@DarkLight1337 wait - something went really wrong here, there are some strange commits that appeared from nowhere? Let me fix it before merging please. |
Signed-off-by: Thomas Parnell <[email protected]>
cd72c2e to
8ba1564
Compare
|
@DarkLight1337 ok. it's fixed and good to go now |
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Update docs to reflect status since #22151 was merged.
Test Plan
Test Result
(Optional) Documentation Update