Skip to content

Conversation

@tdoublep
Copy link
Member

@tdoublep tdoublep commented Aug 9, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Update docs to reflect status since #22151 was merged.

Test Plan

Test Result

(Optional) Documentation Update

@tdoublep tdoublep requested a review from hmellor as a code owner August 9, 2025 06:59
@github-actions
Copy link

github-actions bot commented Aug 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Aug 9, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates documentation to reflect Minimax-Text model support. The changes correctly mark MiniMaxText01ForCausalLM as supported in V1. However, there's an inconsistency regarding MiniMaxM1ForCausalLM. While docs/usage/v1_guide.md states it's supported, docs/models/supported_models.md is not updated to reflect this. Since both models use the same implementation, MiniMaxM1ForCausalLM should also be marked as V1 supported in the table for consistency.

@tdoublep tdoublep force-pushed the minimax-doc-update branch from 87ab7b3 to ad09273 Compare August 9, 2025 07:02
@tdoublep tdoublep force-pushed the minimax-doc-update branch from cad5556 to cd72c2e Compare August 9, 2025 07:08
@mergify mergify bot added the rocm Related to AMD ROCm label Aug 9, 2025
@tdoublep
Copy link
Member Author

tdoublep commented Aug 9, 2025

@DarkLight1337 wait - something went really wrong here, there are some strange commits that appeared from nowhere? Let me fix it before merging please.

@tdoublep tdoublep force-pushed the minimax-doc-update branch from cd72c2e to 8ba1564 Compare August 9, 2025 07:12
@tdoublep
Copy link
Member Author

tdoublep commented Aug 9, 2025

@DarkLight1337 ok. it's fixed and good to go now

@vllm-bot vllm-bot merged commit 2be07a0 into vllm-project:main Aug 9, 2025
5 of 9 checks passed
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Diego-Castan <[email protected]>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants