-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[V0 deprecation] Deprecate V0 Neuron backend #21159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request cleanly deprecates and removes the V0 Neuron backend. The changes are comprehensive, covering not only the core implementation files but also associated tests, examples, CI/CD pipeline configurations, and dependency management files. The removal appears to be thorough, with no obvious leftover code or broken references. I found no issues of high or critical severity. The changes align well with the stated objective of moving Neuron support to a plugin for vLLM V1.
|
Thank you for putting up the changes @WoosukKwon . Will review. |
|
We will pull the changes down to integrate with our V1 internal implementation to test the changes. The changes to support Neuron on vLLM V1 will be published as PRs at the same time. |
|
@WoosukKwon #21082 proposes Neuron as an in-tree implementation (not plugin) on V1 Engine. Please see Change 1 and Change 2 (various options) there. @aarondou let us review the files here and ensure nothing required is actually deleted. |
|
This pull request has merge conflicts that must be resolved before it can be |
|
Certain files (for example |
|
In the spirit of #21690, we plan to move aggressively deleting V0 code. The functionality of V1 can be added back later and a gap in support should be fine for now. Even if we keep Neuron code, with the deletion of scheduler and others, it won't be runnable. |
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
In vLLM V1, Neuron will be supported as a plugin.
See #21082