Skip to content

Conversation

@WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Jul 18, 2025

In vLLM V1, Neuron will be supported as a plugin.

See #21082

Signed-off-by: Woosuk Kwon <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation ci/build speculative-decoding labels Jul 18, 2025
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleanly deprecates and removes the V0 Neuron backend. The changes are comprehensive, covering not only the core implementation files but also associated tests, examples, CI/CD pipeline configurations, and dependency management files. The removal appears to be thorough, with no obvious leftover code or broken references. I found no issues of high or critical severity. The changes align well with the stated objective of moving Neuron support to a plugin for vLLM V1.

@WoosukKwon
Copy link
Collaborator Author

WoosukKwon commented Jul 18, 2025

@aarondou Could you please take a look? I'm actually not sure which part will still be needed for your proposal #21082

@hmellor hmellor moved this to In Progress in V0 Deprecation Jul 18, 2025
@aarondou
Copy link

Thank you for putting up the changes @WoosukKwon . Will review.

@aarondou
Copy link

We will pull the changes down to integrate with our V1 internal implementation to test the changes. The changes to support Neuron on vLLM V1 will be published as PRs at the same time.

@mrinalks
Copy link
Contributor

@WoosukKwon #21082 proposes Neuron as an in-tree implementation (not plugin) on V1 Engine. Please see Change 1 and Change 2 (various options) there. @aarondou let us review the files here and ensure nothing required is actually deleted.

@mergify
Copy link

mergify bot commented Jul 21, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @WoosukKwon.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 21, 2025
@mrinalks mrinalks self-assigned this Jul 21, 2025
@mrinalks mrinalks requested a review from elaineyz July 21, 2025 21:15
@elaineyz
Copy link
Contributor

Certain files (for example vllm/platforms/neuron.py) would need to remain in place if Neuron V1 follows in-tree implementation. We have a separate discussion scheduled for 8/6 to discuss in-tree vs. plugin. Let's hold off on merging this PR until after we get clarity on 8/6.

@simon-mo
Copy link
Collaborator

In the spirit of #21690, we plan to move aggressively deleting V0 code. The functionality of V1 can be added back later and a gap in support should be fine for now. Even if we keep Neuron code, with the deletion of scheduler and others, it won't be runnable.

Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
@mergify mergify bot removed the needs-rebase label Sep 6, 2025
@WoosukKwon WoosukKwon merged commit 4172235 into main Sep 6, 2025
70 of 74 checks passed
@WoosukKwon WoosukKwon deleted the woosuk/deprecate-v0-neuron branch September 6, 2025 23:15
@github-project-automation github-project-automation bot moved this from In Progress to Done in V0 Deprecation Sep 6, 2025
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants