Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Jul 15, 2025

I suddenly started seeing these weird {'default': ['*'], 'help': 'Allowed origins.', 'type': <class 'str'>, 'nargs': '+'} logs on main.

vllm serve RedHatAI/Mistral-Small-3.1-24B-Instruct-2503-quantized.w4a16 --load-format=dummy
INFO 07-15 12:45:46 [__init__.py:253] Automatically detected platform cuda.
{'default': ['*'], 'help': 'Allowed origins.', 'type': <class 'str'>, 'nargs': '+'}
INFO 07-15 12:45:48 [api_server.py:1637] vLLM API server version 0.9.2rc2.dev155+g5b6fe23d0
{'default': ['*'], 'help': 'Allowed origins.', 'type': <class 'str'>, 'nargs': '+'}
INFO 07-15 12:45:48 [cli_args.py:268] non-default args: {'model': 'RedHatAI/Mistral-Small-3.1-24B-Instruct-2503-quantized.w4a16', 'load_format': 'dummy'}
...

It seems #20206 had left a print statement behind from debugging, so this PR removes it.

Now I see the expected:

vllm serve RedHatAI/Mistral-Small-3.1-24B-Instruct-2503-quantized.w4a16 --load-format=dummy
INFO 07-15 13:38:10 [__init__.py:253] Automatically detected platform cuda.
INFO 07-15 13:38:12 [api_server.py:1637] vLLM API server version 0.9.2rc2.dev155+g5b6fe23d0
INFO 07-15 13:38:12 [cli_args.py:267] non-default args: {'model': 'RedHatAI/Mistral-Small-3.1-24B-Instruct-2503-quantized.w4a16', 'load_format': 'dummy'}

@mgoin mgoin requested a review from aarnphm as a code owner July 15, 2025 17:37
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin requested review from hmellor and removed request for aarnphm July 15, 2025 17:37
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes a leftover debugging print statement from vllm/entrypoints/openai/cli_args.py. The change is straightforward and resolves the issue of unintended logs as described. The code is clean and ready to be merged.

@mergify mergify bot added the frontend label Jul 15, 2025
@mgoin mgoin changed the title Remove print left in FrontendArgs.add_cli_args [Frontend] Remove print left in FrontendArgs.add_cli_args Jul 15, 2025
@hmellor hmellor enabled auto-merge (squash) July 15, 2025 17:48
@hmellor hmellor disabled auto-merge July 15, 2025 17:48
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 15, 2025
@hmellor hmellor enabled auto-merge (squash) July 15, 2025 17:55
@mgoin
Copy link
Member Author

mgoin commented Jul 16, 2025

@simon-mo @DarkLight1337 could this get a force merge please?

@vllm-bot vllm-bot merged commit 153c6f1 into vllm-project:main Jul 16, 2025
74 of 78 checks passed
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants