-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
[Frontend] Remove print left in FrontendArgs.add_cli_args #21004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Remove print left in FrontendArgs.add_cli_args #21004
Conversation
Signed-off-by: mgoin <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes a leftover debugging print statement from vllm/entrypoints/openai/cli_args.py. The change is straightforward and resolves the issue of unintended logs as described. The code is clean and ready to be merged.
|
@simon-mo @DarkLight1337 could this get a force merge please? |
…ct#21004) Signed-off-by: mgoin <[email protected]> Signed-off-by: x22x22 <[email protected]>
…ct#21004) Signed-off-by: mgoin <[email protected]>
…ct#21004) Signed-off-by: mgoin <[email protected]>
…ct#21004) Signed-off-by: mgoin <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…ct#21004) Signed-off-by: mgoin <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…ct#21004) Signed-off-by: mgoin <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…ct#21004) Signed-off-by: mgoin <[email protected]>
I suddenly started seeing these weird
{'default': ['*'], 'help': 'Allowed origins.', 'type': <class 'str'>, 'nargs': '+'}logs on main.It seems #20206 had left a
printstatement behind from debugging, so this PR removes it.Now I see the expected: