Skip to content

[Misc] Add security warning for development mode endpoints #20508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vllm-bot merged 1 commit into from
Jul 5, 2025
Merged

[Misc] Add security warning for development mode endpoints #20508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vllm/entrypoints/openai/api_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,8 @@ async def do_rerank_v2(request: RerankRequest, raw_request: Request):
}

if envs.VLLM_SERVER_DEV_MODE:
logger.warning("SECURITY WARNING: Development endpoints are enabled! "
"This should NOT be used in production!")
Comment on lines +913 to +914
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a great addition for security awareness. To prevent accidental removal or changes to this important warning in the future, it would be beneficial to add a test case. The test should enable VLLM_SERVER_DEV_MODE and assert that this warning is logged.


@router.get("/server_info")
async def show_server_info(raw_request: Request):
Expand Down