Skip to content

Conversation

@Abirdcfly
Copy link
Contributor

@Abirdcfly Abirdcfly commented May 29, 2025

No description provided.

@mergify mergify bot added the frontend label May 29, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

DarkLight1337 commented May 29, 2025

Could you elaborate? Which PR made this unused?

@Abirdcfly
Copy link
Contributor Author

Could you elaborate? Which PR made this unused?

maybe #12846 renamed jinaai_serving_reranking to openai_serving_scores?
CleanShot 2025-05-29 at 14 43 53

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, let's rename it to serving_scores instead of openai_serving_scores to be less misleading

@Abirdcfly
Copy link
Contributor Author

Hmm, let's rename it to serving_scores instead of openai_serving_scores to be less misleading

It seems my screenshot may have caused confusion.

The point I intended to convey was that there's a single definition for jinaai_serving_reranking that is not used, and it should be removed.

As for the naming of openai_serving_scores, I suspect it's due to the presence of other related variables in the same class, such as
openai_serving_models,
openai_serving_chat,
openai_serving_completion,
openai_serving_pooling,
openai_serving_embedding,
openai_serving_classification,
openai_serving_tokenization,
openai_serving_transcription.

@DarkLight1337
Copy link
Member

That's because the other APIs follow OpenAI API. However, this one does not, so I think it's better to have a different name for it to avoid confusion.

@Abirdcfly Abirdcfly requested a review from aarnphm as a code owner July 2, 2025 02:27
@Abirdcfly Abirdcfly changed the title [Chore] remove unused jinaai_serving_reranking [Misc] remove unused jinaai_serving_reranking Jul 2, 2025
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, LGTM

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 7, 2025 04:04
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 7, 2025
@DarkLight1337 DarkLight1337 merged commit 448acad into vllm-project:main Jul 7, 2025
70 of 72 checks passed
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants