Skip to content

[BugFix] [Vul] Add missing usedforsecurity=False in MD5 hashing to enable FIPS #18319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2025
Merged

[BugFix] [Vul] Add missing usedforsecurity=False in MD5 hashing to enable FIPS #18319

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90b3234
Support sequence parallelism combined with pipeline parallelism (#18243)
cascade812 May 17, 2025
cf48263
fix: add to enable FIPS
shaoyuyoung May 18, 2025
492dd70
Merge branch 'vllm-project:main' into fix_md5_hashing
shaoyuyoung May 18, 2025
a11d3dc
Fix pre-commit issues
shaoyuyoung May 18, 2025
41ddf8c
Merge branch 'fix_md5_hashing' of https://github.com/shaoyuyoung/vllm…
shaoyuyoung May 18, 2025
7e4e7c8
Merge branch 'vllm-project:main' into fix_md5_hashing
shaoyuyoung May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions vllm/model_executor/model_loader/neuronx_distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ def load_weights(self, model_name_or_path: str, **kwargs):
config = neuronx_model_cls.get_config_cls()(
neuron_config,
load_config=load_pretrained_config(model_name_or_path))
hashed_config = hashlib.md5(
config.to_json_string().encode('utf-8')).hexdigest()
hashed_config = hashlib.md5(config.to_json_string().encode('utf-8'),
usedforsecurity=False).hexdigest()
if os.getenv("NEURON_COMPILED_ARTIFACTS") is not None:
compiled_model_path = os.getenv("NEURON_COMPILED_ARTIFACTS")
elif os.path.exists(model_name_or_path):
Expand Down Expand Up @@ -263,8 +263,8 @@ def load_weights(self, model_name_or_path: str, **kwargs):
config = neuronx_model_cls.get_config_cls()(
neuron_config,
load_config=load_pretrained_config(model_name_or_path))
hashed_config = hashlib.md5(
config.to_json_string().encode('utf-8')).hexdigest()
hashed_config = hashlib.md5(config.to_json_string().encode('utf-8'),
usedforsecurity=False).hexdigest()
if os.getenv("NEURON_COMPILED_ARTIFACTS") is not None:
compiled_model_path = os.getenv("NEURON_COMPILED_ARTIFACTS")
elif os.path.exists(model_name_or_path):
Expand Down Expand Up @@ -426,8 +426,8 @@ def load_weights(self, model_name_or_path: str,
config.fused_spec_config = fused_spec_config
self.config.neuron_config = neuron_config

hashed_config = hashlib.md5(
config.to_json_string().encode('utf-8')).hexdigest()
hashed_config = hashlib.md5(config.to_json_string().encode('utf-8'),
usedforsecurity=False).hexdigest()
if os.getenv("NEURON_COMPILED_ARTIFACTS") is not None:
compiled_model_path = os.getenv("NEURON_COMPILED_ARTIFACTS")
elif os.path.exists(model_name_or_path):
Expand Down