Skip to content

Conversation

@learner0810
Copy link
Contributor

@learner0810 learner0810 commented May 16, 2025

Fix (partial) #15697

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@learner0810 learner0810 force-pushed the feat/dbrx-use-autoweights branch from d2df576 to d781b65 Compare May 16, 2025 07:27
@DarkLight1337
Copy link
Member

Thanks for working on this, can you fix the pre-commit?

@learner0810 learner0810 force-pushed the feat/dbrx-use-autoweights branch 2 times, most recently from 7cd57c8 to 76e66a3 Compare May 16, 2025 08:40
@learner0810
Copy link
Contributor Author

Thanks for working on this, can you fix the pre-commit?

Thanks for the heads up, it's been fixed

@learner0810 learner0810 force-pushed the feat/dbrx-use-autoweights branch from 76e66a3 to fdc0b8b Compare May 16, 2025 11:11
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 16, 2025 12:11
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 16, 2025
@vllm-bot vllm-bot merged commit 87d8714 into vllm-project:main May 16, 2025
61 of 66 checks passed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants