Skip to content

Conversation

@aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented May 7, 2025

This PR cleanups the model id for some structured outputs examples
where before it was hard coded. This PR will determine this model id
from clien such that it will work based on the models users tests with vllm serve

Signed-off-by: Aaron Pham [email protected]

@aarnphm aarnphm requested a review from russellb May 7, 2025 20:29
@github-actions
Copy link

github-actions bot commented May 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@aarnphm aarnphm changed the title [Chore] uses model id determined from OpenAI client [Chore][Doc] uses model id determined from OpenAI client May 7, 2025
@mergify mergify bot added the documentation Improvements or additions to documentation label May 7, 2025
@russellb russellb enabled auto-merge (squash) May 7, 2025 20:48
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 7, 2025
@russellb russellb merged commit a8238bb into vllm-project:main May 8, 2025
54 checks passed
@aarnphm aarnphm deleted the chore/cleanup-examples-model-query branch May 8, 2025 01:57
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed structured-output

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants