Skip to content

[Bugfix] Fix missing lora name mapping for lora without prefix #17793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

[Bugfix] Fix missing lora name mapping for lora without prefix #17793

merged 2 commits into from
May 7, 2025

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented May 7, 2025 •
edited by github-actions bot
Loading

  • Fix missing weights_mapper._map_name for LoRA that doesn't have base_model.model. prefix.

Isotr0py added 2 commits May 7, 2025 14:53
@Isotr0py
fix lora name parser
d753ad6 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix hashing
647344a 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py requested a review from jeejeelee May 7, 2025 12:41
@github-actions
Copy link

github-actions bot commented May 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label May 7, 2025
@Isotr0py Isotr0py enabled auto-merge (squash) May 7, 2025 15:38
@Isotr0py Isotr0py merged commit f98e307 into vllm-project:main May 7, 2025
76 checks passed
@Isotr0py Isotr0py deleted the fix-lora-name branch May 8, 2025 03:13
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
@Isotr0py @princepride
[Bugfix] Fix missing lora name mapping for lora without prefix (vllm-…
3f7dcec 
…project#17793)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: 汪志鹏 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Isotr0py
[Bugfix] Fix missing lora name mapping for lora without prefix (vllm-…
32309f7 
…project#17793)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@Isotr0py @mawong-amd
[Bugfix] Fix missing lora name mapping for lora without prefix (vllm-…
4603549 
…project#17793)

Signed-off-by: Isotr0py <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@Isotr0py
[Bugfix] Fix missing lora name mapping for lora without prefix (vllm-…
dbd97d1 
…project#17793)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Isotr0py @jeejeelee