Skip to content

[Misc] Use apply_rotary_emb from vllm_flash_attn for Qwen2-VL vision RoPE #17726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

[Misc] Use apply_rotary_emb from vllm_flash_attn for Qwen2-VL vision RoPE #17726

merged 2 commits into from
May 7, 2025

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented May 6, 2025 •
edited by github-actions bot
Loading

  • Since we have ported FA's RoPE kernel in vllm_flash_attn, there is no need to use original FA's apply_rotary_emb anymore
  • Replace original FA's apply_rotary_emb with vllm_flash_attn's

Isotr0py added 2 commits May 6, 2025 23:18
@Isotr0py
use vllm-fa for qwen2vl vision rope
294e45e 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix import
a567ca9 
Signed-off-by: Isotr0py <[email protected]>
@github-actions
Copy link

github-actions bot commented May 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

jeejeelee
jeejeelee approved these changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 7, 2025 02:51
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 7, 2025
@DarkLight1337 DarkLight1337 merged commit c3e9d50 into vllm-project:main May 7, 2025
73 of 74 checks passed
@Isotr0py Isotr0py deleted the vision-rope branch May 7, 2025 05:01
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Isotr0py
[Misc] Use apply_rotary_emb from vllm_flash_attn for Qwen2-VL visio…
293d563 
…n RoPE (vllm-project#17726)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@Isotr0py @mawong-amd
[Misc] Use apply_rotary_emb from vllm_flash_attn for Qwen2-VL visio…
d100457 
…n RoPE (vllm-project#17726)

Signed-off-by: Isotr0py <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@Isotr0py
[Misc] Use apply_rotary_emb from vllm_flash_attn for Qwen2-VL visio…
1d5f2aa 
…n RoPE (vllm-project#17726)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Isotr0py @jeejeelee @DarkLight1337