Skip to content

Replace lm-eval bash script with pytest and use enforce_eager for faster CI #17717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

Replace lm-eval bash script with pytest and use enforce_eager for faster CI #17717

merged 3 commits into from
May 7, 2025

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented May 6, 2025 •
edited by github-actions bot
Loading

@mgoin mgoin requested a review from simon-mo as a code owner May 6, 2025 13:08
@github-actions
Copy link

github-actions bot commented May 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin
Remove bash script
fac6a00 
Signed-off-by: mgoin <[email protected]>
@mergify mergify bot added the ci/build label May 6, 2025
@mgoin mgoin requested a review from robertgshaw2-redhat May 6, 2025 13:09
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label May 6, 2025
@simon-mo simon-mo merged commit 950b711 into vllm-project:main May 7, 2025
98 of 100 checks passed
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@mgoin
Replace lm-eval bash script with pytest and use enforce_eager for fas…
108731d 
…ter CI (vllm-project#17717)

Signed-off-by: mgoin <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@mgoin @mawong-amd
Replace lm-eval bash script with pytest and use enforce_eager for fas…
12b0d38 
…ter CI (vllm-project#17717)

Signed-off-by: mgoin <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@mgoin
Replace lm-eval bash script with pytest and use enforce_eager for fas…
6d82b2f 
…ter CI (vllm-project#17717)

Signed-off-by: mgoin <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon-mo simon-mo Awaiting requested review from simon-mo

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgoin @simon-mo