Skip to content

[Build/CI] Upgrade CUTLASS to 3.9.1 #17602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

[Build/CI] Upgrade CUTLASS to 3.9.1 #17602

merged 1 commit into from
May 3, 2025

Conversation

@tlrmchlsmth
Copy link
Member

@tlrmchlsmth tlrmchlsmth commented May 2, 2025 •
edited by github-actions bot
Loading

From the release notes:

  • Fixed Group Gemm hang issue in CUTLASS 3.x
  • Improved Hopper Blockwise and Groupwise GEMM performance.

Not sure if the Group Gemm hang issue affects us but definitely prompted me to upgrade.

Also unifies the CUTLASS revision so the two spots don't get out of sync.

@tlrmchlsmth
[Build/CI] Upgrade CUTLASS to 3.9.1
04cd812 
Signed-off-by: Tyler Michael Smith <[email protected]>
@github-actions
Copy link

github-actions bot commented May 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 2, 2025
LucasWilkinson
LucasWilkinson approved these changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming CI passes)

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label May 2, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) May 2, 2025 22:19
@vllm-bot vllm-bot merged commit c8386fa into main May 3, 2025
101 of 105 checks passed
@vllm-bot vllm-bot deleted the cutlass_3.9.1 branch May 3, 2025 05:25
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@tlrmchlsmth
[Build/CI] Upgrade CUTLASS to 3.9.1 (vllm-project#17602)
d7826a8 
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@tlrmchlsmth @mawong-amd
[Build/CI] Upgrade CUTLASS to 3.9.1 (vllm-project#17602)
c0a2073 
Signed-off-by: Tyler Michael Smith <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@tlrmchlsmth
[Build/CI] Upgrade CUTLASS to 3.9.1 (vllm-project#17602)
bb3a24e 
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LucasWilkinson LucasWilkinson LucasWilkinson approved these changes

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tlrmchlsmth @LucasWilkinson @vllm-bot