-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[Quantizaton] [AMD] Add support for running DeepSeek int8 w8a8 MoE on ROCm #17558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Randall Smith <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Randall Smith <[email protected]>
Signed-off-by: Randall Smith <[email protected]>
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you
|
|
||
| if current_platform.is_rocm(): | ||
| cutlass_compatible_b = (b.shape[0] % 16 == 0 and b.shape[1] % 16 == 0) | ||
| if current_platform.is_rocm() or not cutlass_compatible_b: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this could change behavior for CUDA since it will now run the triton kernel if the cutlass kernel isn't satisfied
… ROCm (vllm-project#17558) Signed-off-by: Randall Smith <[email protected]> Signed-off-by: Mu Huai <[email protected]>
… ROCm (vllm-project#17558) Signed-off-by: Randall Smith <[email protected]>
… ROCm (vllm-project#17558) Signed-off-by: Randall Smith <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
This PR makes it possible to use DeepSeek int8 w8a8 MoE on ROCm. This PR #16745 will need to merge before it works, but these are the modifications needed for it to work.
With these modifications and the above PR, I can now run: nm-testing/DeepSeek-Coder-V2-Lite-Instruct-quantized.w8a8
I also had to add an implementation for
roundto work on ROCm sincelibdevice.hip.rounddoesn't exist, but once it becomes available, should be possible to remove this.