Skip to content

Conversation

@rasmith
Copy link
Contributor

@rasmith rasmith commented May 1, 2025

This PR makes it possible to use DeepSeek int8 w8a8 MoE on ROCm. This PR #16745 will need to merge before it works, but these are the modifications needed for it to work.

With these modifications and the above PR, I can now run: nm-testing/DeepSeek-Coder-V2-Lite-Instruct-quantized.w8a8

I also had to add an implementation for round to work on ROCm since libdevice.hip.round doesn't exist, but once it becomes available, should be possible to remove this.

@github-actions
Copy link

github-actions bot commented May 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

rasmith added 2 commits May 1, 2025 20:07
Signed-off-by: Randall Smith <[email protected]>
Signed-off-by: Randall Smith <[email protected]>
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you


if current_platform.is_rocm():
cutlass_compatible_b = (b.shape[0] % 16 == 0 and b.shape[1] % 16 == 0)
if current_platform.is_rocm() or not cutlass_compatible_b:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this could change behavior for CUDA since it will now run the triton kernel if the cutlass kernel isn't satisfied

@mgoin mgoin added rocm Related to AMD ROCm ready ONLY add when PR is ready to merge/full CI is needed labels May 2, 2025
@vllm-bot vllm-bot merged commit e3d0a1d into vllm-project:main May 3, 2025
74 of 76 checks passed
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants