Skip to content

Conversation

@n0gu-furiosa
Copy link
Contributor

@n0gu-furiosa n0gu-furiosa commented Apr 24, 2025

In benchmark_serving.py, the --save-detailed flag is always applied, even when not specified, because the code attempts to remove detail keys from an incorrect dictionary.

This PR corrects the logic to ensure that detailed output is only saved when the flag is explicitly enabled.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@n0gu-furiosa n0gu-furiosa force-pushed the benchmark-fix-save-detailed branch from 87c2679 to 02852c7 Compare April 25, 2025 00:49
@DarkLight1337
Copy link
Member

Thanks for the bugfix! However it's no longer required after #17028 so I'll close this issue

@n0gu-furiosa n0gu-furiosa deleted the benchmark-fix-save-detailed branch April 25, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants